The current API for FileMonitor is fragile, because it requires the user to manually stop the monitor to make sure it is properly cleaned up. This was done to make sure the event handler would never be left with a dangling this pointer. Instead, we should vend a WeakPtr to the closure, and check it when processing events to see if the FileMonitor was destroyed. If it was, we don't need to take any action. This will allow the object to properly terminate monitoring when the object goes out of scope.
Created attachment 314745 [details] Patch
Created attachment 314746 [details] Patch
Comment on attachment 314746 [details] Patch Looks good! Nice cleanup.
Comment on attachment 314746 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=314746&action=review > Source/WebCore/platform/FileMonitor.cpp:-46 > -} Much simpler!
Comment on attachment 314746 [details] Patch Clearing flags on attachment: 314746 Committed r219219: <http://trac.webkit.org/changeset/219219>
All reviewed patches have been landed. Closing bug.