WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
174162
Rename source directory and project files from WebKit to WebKitLegacy
https://bugs.webkit.org/show_bug.cgi?id=174162
Summary
Rename source directory and project files from WebKit to WebKitLegacy
Matthew Hanson
Reported
2017-07-05 10:18:49 PDT
The WebKitLegacy framework is confusingly dubbed "WebKit" in source code and project files. This bug tracks the rename of these source directories, project files, and references to them. My proposal for this work encompasses four distinct tasks: 1. Rename the source directory The proposed rename is: Source/WebKit/ => Source/WebKitLegacy/ 2. Rename relevant Makefiles, tools, configurations, etc... This must be done in conjunction with (1). If done in separate commits, the commits should be contiguous. 3. Rename the Xcode project The proposed rename is: Source/WebKit/WebKit.xcodeproj => Source/WebKitLegacy/WebKitLegacy.xcodeproj 4. Rename the Visual Studio project The proposed rename is: Source/WebKit/WebKit.vcxproj => Source/WebKitLegacy/WebKitLegacy.vcxproj
Attachments
Rename + tools/configurations updates + project file updates
(324.77 KB, patch)
2017-07-05 11:30 PDT
,
Matthew Hanson
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2017-07-05 10:48:04 PDT
<
rdar://problem/33137594
>
Matthew Hanson
Comment 2
2017-07-05 11:30:35 PDT
Created
attachment 314625
[details]
Rename + tools/configurations updates + project file updates This patch contains the rename, the tools/configuration updates, and the project file updates for both Xcode and Visual Studio.
Matthew Hanson
Comment 3
2017-07-10 10:53:41 PDT
I've added the Igalia folks to solicit their help in validating the GTK builds + tests.
Michael Catanzaro
Comment 4
2017-07-10 12:58:45 PDT
The GTK EWS failed on an unrelated problem we had when the patch was uploaded five days ago. I'll look closer at this soon, but it's possible it would pass if the patch is just reuploaded.
Matthew Hanson
Comment 5
2017-07-10 13:33:55 PDT
(In reply to Michael Catanzaro from
comment #4
)
> The GTK EWS failed on an unrelated problem we had when the patch was > uploaded five days ago. I'll look closer at this soon, but it's possible it > would pass if the patch is just reuploaded.
Agreed. Because most of the patch is renaming individual files, I'll need to re-generate the patch first. I'm going to try again this afternoon.
Matthew Hanson
Comment 6
2017-07-13 22:21:01 PDT
Resolved in:
https://trac.webkit.org/r219481
https://trac.webkit.org/r219482
https://trac.webkit.org/r219483
https://trac.webkit.org/r219484
https://trac.webkit.org/r219485
https://trac.webkit.org/r219486
https://trac.webkit.org/r219487
https://trac.webkit.org/r219488
https://trac.webkit.org/r219489
https://trac.webkit.org/r219490
https://trac.webkit.org/r219492
https://trac.webkit.org/r219493
https://trac.webkit.org/r219494
https://trac.webkit.org/r219495
https://trac.webkit.org/r219496
https://trac.webkit.org/r219497
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug