Bug 174151 - [WTF] Do not allocate storage when registering static string to AtomicStringTable
Summary: [WTF] Do not allocate storage when registering static string to AtomicStringT...
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-04 22:18 PDT by Yusuke Suzuki
Modified: 2017-07-04 22:23 PDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2017-07-04 22:18:09 PDT
Static strings can be shared among multiple threads. Thus, we cannot register static StringImpl (StringImpl::isStatic() => true) to AtomicStringTable.
When registering it, we newly allocate a StringImpl and register it to the table.

Currently, everytime we register it, we allocate a new storage for underlying string. That is not good.
We should create such a AtomicStringImpl owning original static string.
Comment 1 Yusuke Suzuki 2017-07-04 22:23:25 PDT
Ah, no. It is already done.