RESOLVED FIXED 174150
[WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms 
https://bugs.webkit.org/show_bug.cgi?id=174150
Summary [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
Yusuke Suzuki
Reported 2017-07-04 21:41:15 PDT
[WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
Attachments
Patch (209.63 KB, patch)
2017-07-04 21:57 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2017-07-04 21:57:52 PDT
Created attachment 314598 [details] Patch
Build Bot
Comment 2 2017-07-04 22:00:59 PDT
Attachment 314598 [details] did not pass style-queue: ERROR: Source/WebCore/accessibility/AXObjectCache.cpp:426: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 145 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mark Lam
Comment 3 2017-07-05 10:53:10 PDT
Comment on attachment 314598 [details] Patch r=me
Yusuke Suzuki
Comment 4 2017-07-05 18:34:23 PDT
Comment on attachment 314598 [details] Patch Thank you!
WebKit Commit Bot
Comment 5 2017-07-05 19:02:57 PDT
Comment on attachment 314598 [details] Patch Clearing flags on attachment: 314598 Committed r219178: <http://trac.webkit.org/changeset/219178>
WebKit Commit Bot
Comment 6 2017-07-05 19:02:58 PDT
All reviewed patches have been landed. Closing bug.
Matt Lewis
Comment 7 2017-07-06 09:15:05 PDT
This revision caused an API failure on all Debug testers. The test failing is: StringBuilderTest.ToAtomicStringOnEmpty https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20WK2%20%28Tests%29/builds/2054/steps/run-api-tests/logs/stdio https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/builds/2060 This is causing the trees to stay on a consistent failure.
Matt Lewis
Comment 8 2017-07-06 09:22:47 PDT
Reverted r219178 for reason: This caused a consistent failure with the API test StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers. Committed r219199: <http://trac.webkit.org/changeset/219199>
Yusuke Suzuki
Comment 9 2017-07-06 20:17:22 PDT
(In reply to Matt Lewis from comment #7) > This revision caused an API failure on all Debug testers. The test failing > is: > StringBuilderTest.ToAtomicStringOnEmpty > > https://build.webkit.org/builders/ > Apple%20El%20Capitan%20Debug%20WK2%20%28Tests%29/builds/2054/steps/run-api- > tests/logs/stdio > https://build.webkit.org/builders/ > Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/builds/2060 > > This is causing the trees to stay on a consistent failure. Thanks! This is because of TestWTF's bug. It does not call AtomicString::init() while it uses AtomicString. I'll add it and land it again.
Yusuke Suzuki
Comment 10 2017-07-06 21:42:20 PDT
Committed r219237: <http://trac.webkit.org/changeset/219237>
Note You need to log in before you can comment on or make changes to this bug.