Bug 174135 - FrameView should not set RenderView::logicalWidth directly for printing
Summary: FrameView should not set RenderView::logicalWidth directly for printing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 173574
  Show dependency treegraph
 
Reported: 2017-07-04 09:18 PDT by Antti Koivisto
Modified: 2017-07-05 10:20 PDT (History)
6 users (show)

See Also:


Attachments
patch (8.36 KB, patch)
2017-07-04 09:29 PDT, Antti Koivisto
zalan: review+
Details | Formatted Diff | Diff
patch (8.55 KB, patch)
2017-07-04 10:20 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2017-07-04 09:18:19 PDT
Renderer logicalWidth should be set by layout. Direct override by RenderView when printing means that we don't layout children in all cases when the width changes. This is currently mostly hidden by spurious layouts but causes problems when trying to fix other things that reduces those.
Comment 1 Antti Koivisto 2017-07-04 09:29:16 PDT
Created attachment 314569 [details]
patch
Comment 2 Build Bot 2017-07-04 09:30:27 PDT
Attachment 314569 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderView.h:144:  The parameter name "size" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Antti Koivisto 2017-07-04 10:20:17 PDT
Created attachment 314571 [details]
patch
Comment 4 WebKit Commit Bot 2017-07-04 10:58:40 PDT
Comment on attachment 314571 [details]
patch

Clearing flags on attachment: 314571

Committed r219121: <http://trac.webkit.org/changeset/219121>
Comment 5 WebKit Commit Bot 2017-07-04 10:58:41 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-07-05 10:20:14 PDT
<rdar://problem/33136784>