Bug 174116 - [iOS DnD] [WK2] Callout bar should reappear after dragging ends for a text selection
Summary: [iOS DnD] [WK2] Callout bar should reappear after dragging ends for a text se...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-07-03 19:18 PDT by Wenson Hsieh
Modified: 2017-07-03 21:33 PDT (History)
5 users (show)

See Also:

Attachments
Patch (6.28 KB, patch)
2017-07-03 19:41 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Guard selection UI hiding against multiple item drags. (6.48 KB, patch)
2017-07-03 19:45 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2017-07-03 19:18:17 PDT 
<rdar://problem/33017845>
Comment 1 Wenson Hsieh 2017-07-03 19:41:03 PDT 
Created attachment 314545 [details]
Patch
Comment 2 Wenson Hsieh 2017-07-03 19:45:36 PDT 
Created attachment 314546 [details]
Guard selection UI hiding against multiple item drags.
Comment 3 Ryosuke Niwa 2017-07-03 19:56:34 PDT 
Comment on attachment 314546 [details]
Guard selection UI hiding against multiple item drags.

Oh my, new code surely looks very strange :( Can we somehow fix it in UIKit before making this change?
Comment 4 Wenson Hsieh 2017-07-03 20:00:21 PDT 
(In reply to Ryosuke Niwa from comment #3)
> Comment on attachment 314546 [details]
> Guard selection UI hiding against multiple item drags.
> 
> Oh my, new code surely looks very strange :( Can we somehow fix it in UIKit
> before making this change?

That would be nice, but I preferred not to block this change on a UIKit submission as well :P

Since it's just renaming (but exposing the same functionality) I'll work on a UIKit renaming tweak in parallel, and then when that's in the build, transition WebKit2 over to use the renamed methods.
Comment 5 WebKit Commit Bot 2017-07-03 21:33:24 PDT 
Comment on attachment 314546 [details]
Guard selection UI hiding against multiple item drags.

Clearing flags on attachment: 314546

Committed r219113: <http://trac.webkit.org/changeset/219113>
Comment 6 WebKit Commit Bot 2017-07-03 21:33:26 PDT 
All reviewed patches have been landed.  Closing bug.