Bug 174105 - Teach built-product-archive to create minified archives
Summary: Teach built-product-archive to create minified archives
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lucas Forschler
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-07-03 14:41 PDT by Lucas Forschler
Modified: 2017-07-06 15:51 PDT (History)
6 users (show)

See Also:


Attachments
v1 patch for review (4.08 KB, patch)
2017-07-03 15:03 PDT, Lucas Forschler
lforschler: commit-queue-
Details | Formatted Diff | Diff
v2 patch for review (3.92 KB, patch)
2017-07-03 15:39 PDT, Lucas Forschler
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (1.17 MB, application/zip)
2017-07-03 16:44 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Forschler 2017-07-03 14:41:50 PDT
The mac archives that built-product-archive creates are huge... They contain things which are un-needed.
Teach it to create a new archive which is minified.
Comment 1 Lucas Forschler 2017-07-03 15:03:03 PDT
Created attachment 314525 [details]
v1 patch for review
Comment 2 Lucas Forschler 2017-07-03 15:12:47 PDT
Comment on attachment 314525 [details]
v1 patch for review

View in context: https://bugs.webkit.org/attachment.cgi?id=314525&action=review

> Tools/BuildSlaveSupport/built-product-archive:72
>      else:

I think I should move this check inside archiveBuiltProduct()
Comment 3 Lucas Forschler 2017-07-03 15:39:56 PDT
Created attachment 314527 [details]
v2 patch for review
Comment 4 Lucas Forschler 2017-07-03 16:24:06 PDT
<rdar://problem/32335163>
Comment 5 Build Bot 2017-07-03 16:44:06 PDT
Comment on attachment 314527 [details]
v2 patch for review

Attachment 314527 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4047411

New failing tests:
workers/bomb.html
Comment 6 Build Bot 2017-07-03 16:44:07 PDT
Created attachment 314536 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 7 WebKit Commit Bot 2017-07-03 17:16:40 PDT
Comment on attachment 314527 [details]
v2 patch for review

Clearing flags on attachment: 314527

Committed r219110: <http://trac.webkit.org/changeset/219110>
Comment 8 WebKit Commit Bot 2017-07-03 17:16:42 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Alexey Proskuryakov 2017-07-04 04:20:02 PDT
Comment on attachment 314527 [details]
v2 patch for review

View in context: https://bugs.webkit.org/attachment.cgi?id=314527&action=review

> Tools/BuildSlaveSupport/built-product-archive:46
> +                      help="Create a minified archive")

This help string is not super clear. How can one tell what the consequences of passing this option are?

The should explain that it will remove files that are not necessary for running applications against the built product, at the cost of complicating debugging.
Comment 10 Lucas Forschler 2017-07-06 15:51:39 PDT
Committed revision 219222