Bug 174103 - Add/remove appropriate media element behavior restrictions when updateWebsitePolicies is called
Summary: Add/remove appropriate media element behavior restrictions when updateWebsite...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matt Rajca
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-07-03 14:04 PDT by Matt Rajca
Modified: 2017-07-06 14:25 PDT (History)
8 users (show)

See Also:

Attachments
Patch (26.54 KB, patch)
2017-07-03 14:19 PDT, Matt Rajca 		no flags Details | Formatted Diff | Diff
Patch (22.28 KB, patch)
2017-07-03 14:46 PDT, Matt Rajca 		achristensen: review+
Details | Formatted Diff | Diff
Patch (24.10 KB, patch)
2017-07-03 15:02 PDT, Matt Rajca 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (1.11 MB, application/zip)
2017-07-03 16:14 PDT, Build Bot 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Rajca 2017-07-03 14:04:07 PDT 
When we update website policies on-demand, add/remove media element behavior restrictions to/from any existing media elements.

<rdar://problem/32854043>
Comment 1 Matt Rajca 2017-07-03 14:19:39 PDT 
Created attachment 314517 [details]
Patch
Comment 2 Build Bot 2017-07-03 14:22:02 PDT 
Attachment 314517 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2836:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:805:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Matt Rajca 2017-07-03 14:46:13 PDT 
Created attachment 314520 [details]
Patch
Comment 4 Build Bot 2017-07-03 14:48:47 PDT 
Attachment 314520 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2836:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:805:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Alex Christensen 2017-07-03 14:53:43 PDT 
Comment on attachment 314520 [details]
Patch

r=me.  GTK needs a bool added somewhere.
Comment 6 Matt Rajca 2017-07-03 15:02:38 PDT 
Created attachment 314523 [details]
Patch
Comment 7 Build Bot 2017-07-03 15:04:19 PDT 
Attachment 314523 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2836:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:805:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Build Bot 2017-07-03 16:14:55 PDT 
Comment on attachment 314523 [details]
Patch

Attachment 314523 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4047243

New failing tests:
workers/bomb.html
Comment 9 Build Bot 2017-07-03 16:14:56 PDT 
Created attachment 314532 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 10 Matt Rajca 2017-07-03 16:21:18 PDT 
http://trac.webkit.org/changeset/219106/webkit
Comment 11 Don Olmstead 2017-07-05 15:58:39 PDT 
This breaks builds without ENABLE_VIDEO
Comment 12 Matt Rajca 2017-07-06 14:25:14 PDT 
(In reply to Don Olmstead from comment #11)
> This breaks builds without ENABLE_VIDEO

Fixed, sorry about that!