Bug 174102 – Add better crash logging for allocation sinking phase

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Saam Barati]

Already rubber stamped by Filip.

[Saam Barati]

<rdar://problem/33112092>

[Saam Barati]

Created attachment 314515 [details]
patch for landing

[Build Bot]

Comment on attachment 314515 [details]
patch for landing

Attachment 314515 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4046842

New failing tests:
workers/bomb.html

[Build Bot]

Created attachment 314521 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[WebKit Commit Bot]

Comment on attachment 314515 [details]
patch for landing

Clearing flags on attachment: 314515

Committed r219098: <http://trac.webkit.org/changeset/219098>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Keith Miller]

Comment on attachment 314515 [details]
patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=314515&action=review

> Source/JavaScriptCore/dfg/DFGObjectAllocationSinkingPhase.cpp:53
> +    CRASH_WITH_SECURITY_IMPLICATION_AND_INFO(line);

I think the intention is to use a unique enum value from AbortReason.h otherwise it's harder for our tools to track the crashes over time. At least this is what JF wanted me to do.

[Saam Barati]

Comment on attachment 314515 [details]
patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=314515&action=review

>> Source/JavaScriptCore/dfg/DFGObjectAllocationSinkingPhase.cpp:53
>> +    CRASH_WITH_SECURITY_IMPLICATION_AND_INFO(line);
> 
> I think the intention is to use a unique enum value from AbortReason.h otherwise it's harder for our tools to track the crashes over time. At least this is what JF wanted me to do.

Ok, I'll add one for this. Almost certainly we'll remove this code before we add more reasons, but it's good to stick with the intention of the API