Bug 174088 – [PAL] Helper script to move PAL sources

• Status: NEW
• Component: WebCore Misc.

[Yoshiaki Jitsukawa]

Inspired by the do-file-rename script, I think it'd be helpful to have a script to move PAL relevant sources from WebCore/platform to PAL/pal.

[Yoshiaki Jitsukawa]

Created attachment 314458 [details]
PATCH.

[Yoshiaki Jitsukawa]

This script does
- move files with SCM support
- move entries in CMake files
- rename include/import directives

[Build Bot]

Comment on attachment 314458 [details]
PATCH.

Attachment 314458 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4043499

New failing tests:
workers/bomb.html

[Build Bot]

Created attachment 314477 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Alex Christensen]

Comment on attachment 314458 [details]
PATCH.

Is this really necessary to have in the repository?

[Yoshiaki Jitsukawa]

> Is this really necessary to have in the repository?

It's not, but nice to have.

[Alex Christensen]

Comment on attachment 314458 [details]
PATCH.

View in context: https://bugs.webkit.org/attachment.cgi?id=314458&action=review

> Tools/Scripts/do-pal-move:50
> +my %movesContemplatedForTheFuture = (
> +    "KillRing.h" => "text/KillRing.h",
> +    "KillRingNone.cpp" => "text/none/KillRingNone.cpp",
> +    "mac/KillRingMac.mm" => "text/mac/KillRingMac.mm",

I don't think we should add this to the repository.  Maybe a general move helper, but not this.

[Don Olmstead]

(In reply to Alex Christensen from comment #7)
> Comment on attachment 314458 [details]
> PATCH.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=314458&action=review
> 
> > Tools/Scripts/do-pal-move:50
> > +my %movesContemplatedForTheFuture = (
> > +    "KillRing.h" => "text/KillRing.h",
> > +    "KillRingNone.cpp" => "text/none/KillRingNone.cpp",
> > +    "mac/KillRingMac.mm" => "text/mac/KillRingMac.mm",
> 
> I don't think we should add this to the repository.  Maybe a general move
> helper, but not this.

That works for me. We can take a look at the two files that are currently there and see what a more general purpose one might look like,

[Yoshiaki Jitsukawa]

Thanks for the comments. I though it was good to write a script based on "do-file-rename" and "do-webcore-rename" but probably what is time consuming when moving PAL files is to maintain the affected files by the move, not to manage svn/git and builds. Let me look for some other approach to make it more general.