[WebIDL] Remove more unnecessary uses of the preprocessor in idl files
Created attachment 314439 [details] Patch
Attachment 314439 [details] did not pass style-queue: ERROR: Source/WebKit/mac/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible. [featuredefines/equality] [5] ERROR: Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible. [featuredefines/equality] [5] ERROR: Source/WebCore/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible. [featuredefines/equality] [5] ERROR: Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible. [featuredefines/equality] [5] ERROR: Source/WebKit2/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible. [featuredefines/equality] [5] Total errors found: 5 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Only 4 uses of the preprocessor for IDLs remain: - DeviceOrientationEvent has an #if defined(WTF_PLATFORM_IOS). We should see if we can merge the iOS and standards track implementations. This would require adding support for the 'absolute' property. - Document.idl has a union, RenderingContext, that has items that are conditionally supported. - CanvasRenderingContext2D.idl has a union, CanvasImageSource, that has items that are conditionally supported. - HTMLMediaElement has has a union, MediaProvider, that has items that are conditionally supported. Solving these three are more difficult, as we don't have a good model of this conditionality. We should look into extended attributes on the union members for this.
Comment on attachment 314439 [details] Patch Let's definitely stop running all these files through the C preprocessor.
Comment on attachment 314439 [details] Patch Clearing flags on attachment: 314439 Committed r219097: <http://trac.webkit.org/changeset/219097>
All reviewed patches have been landed. Closing bug.
Reopening to attach new patch.
Created attachment 314757 [details] Patch