Bug 174079 - REGRESSION(Variation Fonts): Specifying Skia by PostScript name does not yield the expected result
Summary: REGRESSION(Variation Fonts): Specifying Skia by PostScript name does not yiel...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-07-02 13:13 PDT by Myles C. Maxfield
Modified: 2017-07-03 15:47 PDT (History)
6 users (show)

See Also:

Attachments
Patch (10.31 KB, patch)
2017-07-02 13:18 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (11.19 KB, patch)
2017-07-02 13:23 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (11.45 KB, patch)
2017-07-02 14:22 PDT, Myles C. Maxfield 		achristensen: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2017-07-02 13:13:38 PDT 
REGRESSION(Variation Fonts): Specifying Skia by PostScript name does not yield the expected result
Comment 1 Myles C. Maxfield 2017-07-02 13:18:53 PDT 
Created attachment 314423 [details]
Patch
Comment 2 Myles C. Maxfield 2017-07-02 13:23:50 PDT 
Created attachment 314424 [details]
Patch
Comment 3 Myles C. Maxfield 2017-07-02 14:22:22 PDT 
Created attachment 314427 [details]
Patch
Comment 4 Myles C. Maxfield 2017-07-02 14:23:19 PDT 
<rdar://problem/33040854>
Comment 5 Alex Christensen 2017-07-03 15:06:09 PDT 
Comment on attachment 314427 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314427&action=review

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1165
> +        return { adoptCF(CTFontCreateWithFontDescriptor(installedFont->fontDescriptor.get(), size, nullptr)), false };

This false is unnecessary.  Does it help with readability?
Comment 6 Myles C. Maxfield 2017-07-03 15:46:33 PDT 
Committed r219102: <http://trac.webkit.org/changeset/219102>
Comment 7 Myles C. Maxfield 2017-07-03 15:47:32 PDT 
Comment on attachment 314427 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314427&action=review

>> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1165
>> +        return { adoptCF(CTFontCreateWithFontDescriptor(installedFont->fontDescriptor.get(), size, nullptr)), false };
> 
> This false is unnecessary.  Does it help with readability?

Yeah. In the other cases it doesn't matter, but in this case, it's explicitly necessary.