Bug 174075 - Expose unobscuredSafeAreaInsets on WebView
Summary: Expose unobscuredSafeAreaInsets on WebView
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-07-02 00:18 PDT by Tim Horton
Modified: 2017-07-03 11:56 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.79 KB, patch)
2017-07-02 00:21 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (2.96 KB, patch)
2017-07-03 01:36 PDT, Tim Horton 		bdakin: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (1.44 MB, application/zip)
2017-07-03 04:38 PDT, Build Bot 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2017-07-02 00:18:41 PDT 
Expose unobscuredSafeAreaInsets on WebView
Comment 1 Radar WebKit Bug Importer 2017-07-02 00:19:34 PDT 
<rdar://problem/33096997>
Comment 2 Tim Horton 2017-07-02 00:21:15 PDT 
Created attachment 314408 [details]
Patch
Comment 3 Ryosuke Niwa 2017-07-02 02:26:48 PDT 
Looks like this patch is failing to build?

/Volumes/Data/EWS/WebKit/Source/WebKit/mac/WebView/WebView.mm:1123:17: error: property '_unobscuredSafeAreaInsets' requires method '_unobscuredSafeAreaInsets' to be defined - use @dynamic or provide a method implementation in this category [-Werror,-Wobjc-property-implementation]
@implementation WebView (WebPrivate)
                ^
In file included from /Volumes/Data/EWS/WebKit/Source/WebKit/mac/WebView/WebView.mm:31:
In file included from /Volumes/Data/EWS/WebKit/Source/WebKit/mac/WebView/WebViewInternal.h:33:
/Volumes/Data/EWS/WebKit/Source/WebKit/mac/WebView/WebViewPrivate.h:927:83: note: property declared here
@property (nonatomic, assign, setter=_setUnobscuredSafeAreaInsets:) WebEdgeInsets _unobscuredSafeAreaInsets;
                                                                                  ^
/Volumes/Data/EWS/WebKit/Source/WebKit/mac/WebView/WebView.mm:1123:17: error: property '_unobscuredSafeAreaInsets' requires method '_setUnobscuredSafeAreaInsets:' to be defined - use @dynamic or provide a method implementation in this category [-Werror,-Wobjc-property-implementation]
@implementation WebView (WebPrivate)
                ^
In file included from /Volumes/Data/EWS/WebKit/Source/WebKit/mac/WebView/WebView.mm:31:
In file included from /Volumes/Data/EWS/WebKit/Source/WebKit/mac/WebView/WebViewInternal.h:33:
/Volumes/Data/EWS/WebKit/Source/WebKit/mac/WebView/WebViewPrivate.h:927:83: note: property declared here
@property (nonatomic, assign, setter=_setUnobscuredSafeAreaInsets:) WebEdgeInsets _unobscuredSafeAreaInsets;
Comment 4 Tim Horton 2017-07-03 01:33:05 PDT 
On Mac, yeah. I will fix it.
Comment 5 Tim Horton 2017-07-03 01:36:54 PDT 
Created attachment 314465 [details]
Patch
Comment 6 Build Bot 2017-07-03 04:38:27 PDT 
Comment on attachment 314465 [details]
Patch

Attachment 314465 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4043237

New failing tests:
workers/bomb.html
Comment 7 Build Bot 2017-07-03 04:38:28 PDT 
Created attachment 314472 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 8 Beth Dakin 2017-07-03 10:40:27 PDT 
Comment on attachment 314465 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314465&action=review

> Source/WebKit/mac/WebView/WebView.mm:5161
> +

Blank space.
Comment 9 Tim Horton 2017-07-03 11:56:00 PDT 
https://trac.webkit.org/changeset/219084/webkit