Bug 174071 - Expose viewport-fit value to UIKit via viewport arguments dictionary
Summary: Expose viewport-fit value to UIKit via viewport arguments dictionary
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-07-01 21:42 PDT by Tim Horton
Modified: 2017-07-01 23:48 PDT (History)
6 users (show)

See Also:


Attachments
Patch (6.11 KB, patch)
2017-07-01 21:43 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (6.17 KB, patch)
2017-07-01 21:45 PDT, Tim Horton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2017-07-01 21:42:33 PDT
Expose viewport-fit value to UIKit via viewport arguments dictionary
Comment 1 Tim Horton 2017-07-01 21:43:20 PDT
Created attachment 314400 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2017-07-01 21:43:57 PDT
<rdar://problem/33096620>
Comment 3 Tim Horton 2017-07-01 21:45:38 PDT
Created attachment 314401 [details]
Patch
Comment 4 Build Bot 2017-07-01 21:46:37 PDT
Attachment 314401 [details] did not pass style-queue:


ERROR: Source/WebKit/ios/WebCoreSupport/WebChromeClientIOS.mm:210:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit/ios/WebCoreSupport/WebChromeClientIOS.mm:211:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit/ios/WebCoreSupport/WebChromeClientIOS.mm:212:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit/ios/WebCoreSupport/WebChromeClientIOS.mm:213:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit/ios/WebCoreSupport/WebChromeClientIOS.mm:214:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit/ios/WebCoreSupport/WebChromeClientIOS.mm:215:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit/ios/WebCoreSupport/WebChromeClientIOS.mm:216:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 7 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Wenson Hsieh 2017-07-01 23:14:55 PDT
Comment on attachment 314401 [details]
Patch

r=me

It's a bit strange that these are all in WebHistoryItem* files :/
Comment 6 Tim Horton 2017-07-01 23:18:44 PDT
(In reply to Wenson Hsieh from comment #5)
> Comment on attachment 314401 [details]
> Patch
> 
> r=me
> 
> It's a bit strange that these are all in WebHistoryItem* files :/

Only a bit?
Comment 7 WebKit Commit Bot 2017-07-01 23:48:05 PDT
Comment on attachment 314401 [details]
Patch

Clearing flags on attachment: 314401

Committed r219057: <http://trac.webkit.org/changeset/219057>
Comment 8 WebKit Commit Bot 2017-07-01 23:48:06 PDT
All reviewed patches have been landed.  Closing bug.