Bug 174070 – REGRESSION (r217522): "Show My Relationship" link in familysearch.org does not work.

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

rdar://problem/32940653

[zalan]

Created attachment 314404 [details]
Patch

[zalan]

alternatively we could take a more conservative change to fix familysearch.org/hbr.org

[zalan]

Created attachment 314493 [details]
Patch

[zalan]

Created attachment 314495 [details]
Patch

[Build Bot]

Comment on attachment 314495 [details]
Patch

Attachment 314495 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4045880

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 314505 [details]
Archive of layout-test-results from ews117 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[zalan]

Created attachment 314507 [details]
Patch

[Build Bot]

Comment on attachment 314507 [details]
Patch

Attachment 314507 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4046646

New failing tests:
workers/bomb.html

[Build Bot]

Created attachment 314516 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 314507 [details]
Patch

Attachment 314507 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4047140

New failing tests:
imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/centering.html

[Build Bot]

Created attachment 314529 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[zalan]

(In reply to Build Bot from comment #10)
> Comment on attachment 314507 [details]
> Patch
> 
> Attachment 314507 [details] did not pass ios-sim-ews (ios-simulator-wk2):
> Output: http://webkit-queues.webkit.org/results/4047140
> 
> New failing tests:
> imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-
> dialog-element/centering.html
Crashes, really? I don't think so.

[zalan]

Created attachment 314540 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 314540 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314540&action=review

> Source/WebCore/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=174070

Radar number here. Also mention hbr.org

> Source/WebCore/ChangeLog:8
> +        Decouple in and out of flow computed position values.

"in- and out-of-flow". Mention compat with other browsers.

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:794
> +    // Inflow element.

In-flow

> LayoutTests/ChangeLog:8
> +        * fast/css/getComputedStyle/computed-style-expected.txt:

Does this test exercise all the code paths (out of flow, relative position, static position, non-block)?

> LayoutTests/imported/w3c/web-platform-tests/css-timing-1/frames-timing-functions-output-expected.txt:6
> +FAIL For an input progress of 0.0, the output of a frames timing function is the first frame assert_equals: expected "0px" but got "auto"
> +FAIL At a frame boundary, the output of a frames timing function is the next frame assert_equals: expected "0px" but got "auto"
> +FAIL For an input progress of 1.0, the output of a frames timing function is the final frame assert_equals: expected "100px" but got "auto"
> +FAIL The number of frames is correctly reflected in the frames timing function output assert_equals: expected "0px" but got "auto"
> +FAIL The number of frames is correctly reflected in the frames timing function output on CSS Transitions assert_equals: expected "0px" but got "100px"

It's odd that these are regressing if we now match Chrome behavior.

[zalan]

Created attachment 314615 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 314615 [details]
Patch

Clearing flags on attachment: 314615

Committed r219151: <http://trac.webkit.org/changeset/219151>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.