Bug 174069 – Add API test for all parts of WebKit1 API related to favicons

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit API

[Brady Eidson]

Add API test for all parts of WebKit1 API related to favicons

WebIconDatabase itself is not API.

But there are some icon-related things that *are* API:
- WebView's "mainFrameIcon" property
- KVO observation of changes to that property
- WebFrameLoadDelegate's "- (void)webView:(WebView *)sender didReceiveIcon:(NSImage *)image forFrame:(WebFrame *)frame" method

Before we gut WebIconDatabase, we should have a test in place for all that API.

[Brady Eidson]

Created attachment 314394 [details]
Patch

[Build Bot]

Attachment 314394 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/mac/WebViewIconLoading.mm:120:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/mac/WebViewIconLoading.mm:137:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Brady Eidson]

Created attachment 314397 [details]
Patch

[Build Bot]

Attachment 314397 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/mac/WebViewIconLoading.mm:186:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/mac/WebViewIconLoading.mm:227:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Brady Eidson]

Created attachment 314398 [details]
Patch

[Andy Estes]

Comment on attachment 314398 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314398&action=review

> Tools/TestWebKitAPI/Tests/mac/WebViewIconLoading.mm:34
> +static bool messageReceived = false;

No = false

[Brady Eidson]

(In reply to Andy Estes from comment #6)
> Comment on attachment 314398 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=314398&action=review
> 
> > Tools/TestWebKitAPI/Tests/mac/WebViewIconLoading.mm:34
> > +static bool messageReceived = false;
> 
> No = false

I'll loop back around and change that when I touch this test in my next patch

[Brady Eidson]

(In bug 174073)

[WebKit Commit Bot]

Comment on attachment 314398 [details]
Patch

Clearing flags on attachment: 314398

Committed r219059: <http://trac.webkit.org/changeset/219059>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Brady Eidson]

Some bots aren't liking this test. Can't reproduce locally (Of course!)

I think I will resolve with https://bugs.webkit.org/show_bug.cgi?id=174073