Add API test for all parts of WebKit1 API related to favicons WebIconDatabase itself is not API. But there are some icon-related things that *are* API: - WebView's "mainFrameIcon" property - KVO observation of changes to that property - WebFrameLoadDelegate's "- (void)webView:(WebView *)sender didReceiveIcon:(NSImage *)image forFrame:(WebFrame *)frame" method Before we gut WebIconDatabase, we should have a test in place for all that API.
Created attachment 314394 [details] Patch
Attachment 314394 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/mac/WebViewIconLoading.mm:120: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/TestWebKitAPI/Tests/mac/WebViewIconLoading.mm:137: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 314397 [details] Patch
Attachment 314397 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/mac/WebViewIconLoading.mm:186: More than one command on the same line [whitespace/newline] [4] ERROR: Tools/TestWebKitAPI/Tests/mac/WebViewIconLoading.mm:227: More than one command on the same line [whitespace/newline] [4] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 314398 [details] Patch
Comment on attachment 314398 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=314398&action=review > Tools/TestWebKitAPI/Tests/mac/WebViewIconLoading.mm:34 > +static bool messageReceived = false; No = false
(In reply to Andy Estes from comment #6) > Comment on attachment 314398 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=314398&action=review > > > Tools/TestWebKitAPI/Tests/mac/WebViewIconLoading.mm:34 > > +static bool messageReceived = false; > > No = false I'll loop back around and change that when I touch this test in my next patch
(In bug 174073)
Comment on attachment 314398 [details] Patch Clearing flags on attachment: 314398 Committed r219059: <http://trac.webkit.org/changeset/219059>
All reviewed patches have been landed. Closing bug.
Some bots aren't liking this test. Can't reproduce locally (Of course!) I think I will resolve with https://bugs.webkit.org/show_bug.cgi?id=174073