Bug 174055 - RealtimeOutgoingVideoSource should pass frame timestamp
Summary: RealtimeOutgoingVideoSource should pass frame timestamp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-06-30 16:31 PDT by youenn fablet
Modified: 2017-07-02 11:43 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.04 KB, patch)
2017-06-30 16:34 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (2.06 KB, patch)
2017-06-30 16:39 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-06-30 16:31:23 PDT 
Previously this was not needed.
Comment 1 youenn fablet 2017-06-30 16:31:56 PDT 
rdar://problem/33062003
Comment 2 youenn fablet 2017-06-30 16:34:10 PDT 
Created attachment 314318 [details]
Patch
Comment 3 Build Bot 2017-06-30 16:37:14 PDT 
Attachment 314318 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSource.cpp:189:  timestamp_us is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 youenn fablet 2017-06-30 16:39:21 PDT 
Created attachment 314320 [details]
Patch
Comment 5 WebKit Commit Bot 2017-07-02 11:43:26 PDT 
Comment on attachment 314320 [details]
Patch

Clearing flags on attachment: 314320

Committed r219058: <http://trac.webkit.org/changeset/219058>
Comment 6 WebKit Commit Bot 2017-07-02 11:43:27 PDT 
All reviewed patches have been landed.  Closing bug.