Bug 174035 – When setting a custom cookie storage location on a WKWebsiteDataStore, cookies aren't actually removed

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Brady Eidson]

When setting a custom cookie storage location on a WKWebsiteDataStore, cookies aren't actually removed

When the networking process doesn't exist yet, and then the operation launches it, it doesn't know about the WebsiteDataStore.

[Brady Eidson]

<rdar://problem/32410662>

[Brady Eidson]

Created attachment 314322 [details]
Patch v1

[Ryosuke Niwa]

Comment on attachment 314322 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=314322&action=review

> Source/WebKit2/ChangeLog:7
> +

Could you describe what was causing the bug, and how you're fixing it?
is it that we weren't sending AddWebsiteDataStore when creating a new network process?

[Alex Christensen]

Comment on attachment 314322 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=314322&action=review

r=me

> Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:199
> +    // This time, reuse the same network process but still do a new websitedatastore, to make sure even an existing network process
> +    // gets the new datastore.

No, the problem is described here.  If we have a new WebsiteDataStore and an existing NetworkProcess, we need to tell it about the new WebsiteDataStore.

[WebKit Commit Bot]

Comment on attachment 314322 [details]
Patch v1

Clearing flags on attachment: 314322

Committed r219052: <http://trac.webkit.org/changeset/219052>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.