Bug 174035 - When setting a custom cookie storage location on a WKWebsiteDataStore, cookies aren't actually removed
Summary: When setting a custom cookie storage location on a WKWebsiteDataStore, cookie...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-06-30 13:16 PDT by Brady Eidson
Modified: 2017-07-01 14:37 PDT (History)
4 users (show)

See Also:


Attachments
Patch v1 (9.32 KB, patch)
2017-06-30 16:47 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2017-06-30 13:16:43 PDT
When setting a custom cookie storage location on a WKWebsiteDataStore, cookies aren't actually removed

When the networking process doesn't exist yet, and then the operation launches it, it doesn't know about the WebsiteDataStore.
Comment 1 Brady Eidson 2017-06-30 13:17:21 PDT
<rdar://problem/32410662>
Comment 2 Brady Eidson 2017-06-30 16:47:00 PDT
Created attachment 314322 [details]
Patch v1
Comment 3 Ryosuke Niwa 2017-06-30 21:33:14 PDT
Comment on attachment 314322 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=314322&action=review

> Source/WebKit2/ChangeLog:7
> +

Could you describe what was causing the bug, and how you're fixing it?
is it that we weren't sending AddWebsiteDataStore when creating a new network process?
Comment 4 Alex Christensen 2017-06-30 23:40:37 PDT
Comment on attachment 314322 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=314322&action=review

r=me

> Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:199
> +    // This time, reuse the same network process but still do a new websitedatastore, to make sure even an existing network process
> +    // gets the new datastore.

No, the problem is described here.  If we have a new WebsiteDataStore and an existing NetworkProcess, we need to tell it about the new WebsiteDataStore.
Comment 5 WebKit Commit Bot 2017-07-01 14:37:57 PDT
Comment on attachment 314322 [details]
Patch v1

Clearing flags on attachment: 314322

Committed r219052: <http://trac.webkit.org/changeset/219052>
Comment 6 WebKit Commit Bot 2017-07-01 14:37:59 PDT
All reviewed patches have been landed.  Closing bug.