Bug 174033 – Move ResourceLoadStatisticsStore to WebKit2/UIProcess

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

Move ResourceLoadStatisticsStore to WebKit2/UIProcess as it is only used in the WebKit2 UIProcess.

[Chris Dumez]

Created attachment 314281 [details]
Patch

[Build Bot]

Attachment 314281 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/Storage/ResourceLoadStatisticsStore.h:91:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Brent Fulgham]

Comment on attachment 314281 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314281&action=review

I think this looks great! iOS is happy so far. r=me once the tests pass.

> Source/WebKit2/UIProcess/Storage/ResourceLoadStatisticsStore.cpp:55
> +    auto locker = holdLock(m_statisticsLock);

Now that this is only present in UIProcess, I suspect that this lock can go away, and we can just ASSERT that we are on the work queue.

This comment obviously applies to the rest of this file. But perhaps that should be a separate patch (in case I am wrong!) :-)

> Source/WebKit2/UIProcess/WebResourceLoadStatisticsManager.h:28
> +#include <chrono>

It seems like we are using WallTime everywhere now. I wonder if we can get rid of <chrono> entirely?

[Chris Dumez]

(In reply to Brent Fulgham from comment #3)
> Comment on attachment 314281 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=314281&action=review
> 
> I think this looks great! iOS is happy so far. r=me once the tests pass.

Thanks.

> 
> > Source/WebKit2/UIProcess/Storage/ResourceLoadStatisticsStore.cpp:55
> > +    auto locker = holdLock(m_statisticsLock);
> 
> Now that this is only present in UIProcess, I suspect that this lock can go
> away, and we can just ASSERT that we are on the work queue.
> 
> This comment obviously applies to the rest of this file. But perhaps that
> should be a separate patch (in case I am wrong!) :-)

Separate patch since non-trivial. The WK C API which is used by TestRunner is synchronous and relies on those locks to dose database operations from the main thread still. I plan to fix this in a follow-up.

> 
> > Source/WebKit2/UIProcess/WebResourceLoadStatisticsManager.h:28
> > +#include <chrono>
> 
> It seems like we are using WallTime everywhere now. I wonder if we can get
> rid of <chrono> entirely?

We still use std::chrono in one API, which I have not corrected yet.

[Chris Dumez]

Committed r219010: <http://trac.webkit.org/changeset/219010>