Bug 174019 - [WPE] Fontconfig build breaks with glibc 2.15+
Summary: [WPE] Fontconfig build breaks with glibc 2.15+
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-30 01:51 PDT by Jacobo Aragunde Pérez
Modified: 2017-06-30 06:18 PDT (History)
6 users (show)

See Also:

Attachments
Patch (4.72 KB, patch)
2017-06-30 01:56 PDT, Jacobo Aragunde Pérez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jacobo Aragunde Pérez 2017-06-30 01:51:39 PDT 
Fontconfig build breaks with glibc 2.15+
Comment 1 Jacobo Aragunde Pérez 2017-06-30 01:56:46 PDT 
Created attachment 314249 [details]
Patch
Comment 2 Carlos Garcia Campos 2017-06-30 02:05:16 PDT 
Is the patch included in a newer fontconfig release? I'm fine adding the patch, but maybe it's easier if we just bump fontconfig to a new version (checking the tests to ensure it doesn't affect the results)
Comment 3 Carlos Garcia Campos 2017-06-30 02:07:40 PDT 
I guess we need the same in GTK+, no?
Comment 4 Jacobo Aragunde Pérez 2017-06-30 02:10:58 PDT 
The patch was included in fontconfig 2.12.2 and we are currently using 2.11.1. Latest fontconfig release is 2.12.3.

I can try 2.12.3 and check if the version bump breaks something. I can also check the GTK+ build.
Comment 5 Carlos Garcia Campos 2017-06-30 02:18:11 PDT 
Yes, I would definitely try to use 2.12.3 first. If it builds and test results are not affected (or it's just a matter of a simple rebaseline), it's simpler and better than adding another patch to maintain.
Comment 6 Jacobo Aragunde Pérez 2017-06-30 02:42:36 PDT 
I've noticed the GTK+ fontconfig was already patched.
Comment 7 Carlos Alberto Lopez Perez 2017-06-30 05:51:13 PDT 
Comment on attachment 314249 [details]
Patch

At some point we will want to share the common parts with the WebKitGTK+ moduleset

For the moment i think this is good enough, thanks for the patch.
Comment 8 WebKit Commit Bot 2017-06-30 06:18:43 PDT 
Comment on attachment 314249 [details]
Patch

Clearing flags on attachment: 314249

Committed r218993: <http://trac.webkit.org/changeset/218993>
Comment 9 WebKit Commit Bot 2017-06-30 06:18:44 PDT 
All reviewed patches have been landed.  Closing bug.