Bug 174015 - REGRESSION (High Sierra): Gradient LayoutTests are failing
Summary: REGRESSION (High Sierra): Gradient LayoutTests are failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-06-30 00:12 PDT by Dean Jackson
Modified: 2020-09-04 15:24 PDT (History)
6 users (show)

See Also:

Attachments
Patch (6.95 KB, patch)
2017-06-30 00:13 PDT, Dean Jackson 		thorton: review+
Details | Formatted Diff | Diff
Patch (1.68 KB, patch)
2020-06-26 13:48 PDT, Karl Rackler 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2017-06-30 00:12:39 PDT 
REGRESSION (High Sierra): Gradient LayoutTests are failing
Comment 1 Dean Jackson 2017-06-30 00:13:51 PDT 
Created attachment 314244 [details]
Patch
Comment 2 Dean Jackson 2017-06-30 00:14:47 PDT 
<rdar://problem/32332022>
Comment 3 Tim Horton 2017-06-30 00:19:00 PDT 
Comment on attachment 314244 [details]
Patch

The arguments to this function are mild madness, but already existing so it’s fine.
Comment 4 Dean Jackson 2017-06-30 00:34:15 PDT 
Committed r218990: <http://trac.webkit.org/changeset/218990>
Comment 5 Karl Rackler 2020-06-26 13:29:19 PDT 
imported/w3c/canvas/2d.gradient.interpolate.solid.html is no longer failing - remove expectations

Current history is green: https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fcanvas%2F2d.gradient.interpolate.solid.html
Comment 6 Truitt Savell 2020-06-26 13:43:56 PDT 
Reopening to attach test expectations change.
Comment 7 Karl Rackler 2020-06-26 13:48:16 PDT 
Created attachment 402898 [details]
Patch
Comment 8 EWS 2020-06-26 14:11:31 PDT 
Committed r263582: <https://trac.webkit.org/changeset/263582>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402898 [details].
Comment 9 Darin Adler 2020-09-04 15:24:36 PDT 
We fixed this bug years ago, but TestExpectations still has an entry in it marked with a Radar bug number that is a duplicate of this, claiming it will fail:

# <rdar://problem/32800095> REGRESSION: LayoutTest imported/blink/fast/gradients/gradient-transparency.html is failing
imported/blink/fast/gradients/gradient-transparency.html [ ImageOnlyFailure ]