Bug 174008 - Merge WebResourceLoadStatisticsManager and WebResourceLoadObserver
Summary: Merge WebResourceLoadStatisticsManager and WebResourceLoadObserver
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-29 20:02 PDT by Chris Dumez
Modified: 2017-06-30 09:22 PDT (History)
3 users (show)

See Also:

Attachments
Patch (58.90 KB, patch)
2017-06-29 20:23 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-06-29 20:02:55 PDT 
WebResourceLoadStatisticsManager is currently only a proxy to WebResourceLoadObserver.
Comment 1 Chris Dumez 2017-06-29 20:23:10 PDT 
Created attachment 314217 [details]
Patch
Comment 2 Brent Fulgham 2017-06-29 23:35:26 PDT 
Comment on attachment 314217 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314217&action=review

I think this change looked correct. Another nice simplification.

> Source/WebKit2/UIProcess/API/C/WKResourceLoadStatisticsManager.cpp:58
> +// FIXME: This API name is wrong.

We can change that, it’s only used in testing.
Comment 3 Chris Dumez 2017-06-30 09:06:00 PDT 
(In reply to Brent Fulgham from comment #2)
> Comment on attachment 314217 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=314217&action=review
> 
> I think this change looked correct. Another nice simplification.
> 
> > Source/WebKit2/UIProcess/API/C/WKResourceLoadStatisticsManager.cpp:58
> > +// FIXME: This API name is wrong.
> 
> We can change that, it’s only used in testing.

Sure, can I change it in a follow up. I suspect we may want to make some of this API asynchronous too to avoid locks.
Comment 4 Brent Fulgham 2017-06-30 09:19:09 PDT 
Comment on attachment 314217 [details]
Patch

Wonderful! r=me.
Comment 5 Chris Dumez 2017-06-30 09:22:46 PDT 
Comment on attachment 314217 [details]
Patch

Clearing flags on attachment: 314217

Committed r219000: <http://trac.webkit.org/changeset/219000>
Comment 6 Chris Dumez 2017-06-30 09:22:47 PDT 
All reviewed patches have been landed.  Closing bug.