WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
173999
[PAL] Move Sound into PAL
https://bugs.webkit.org/show_bug.cgi?id=173999
Summary
[PAL] Move Sound into PAL
Ross Kirsling
Reported
2017-06-29 17:32:40 PDT
Move Sound.h to pal/system/Sound.h.
Attachments
Patch
(38.86 KB, patch)
2017-06-29 18:09 PDT
,
Ross Kirsling
no flags
Details
Formatted Diff
Diff
Patch
(45.41 KB, patch)
2017-06-29 21:00 PDT
,
Ross Kirsling
no flags
Details
Formatted Diff
Diff
Patch
(45.48 KB, patch)
2017-06-29 21:47 PDT
,
Ross Kirsling
no flags
Details
Formatted Diff
Diff
Patch
(45.48 KB, patch)
2017-06-29 22:06 PDT
,
Ross Kirsling
no flags
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
Ross Kirsling
Comment 1
2017-06-29 18:09:32 PDT
Created
attachment 314197
[details]
Patch
Ross Kirsling
Comment 2
2017-06-29 21:00:49 PDT
Created
attachment 314223
[details]
Patch
Ross Kirsling
Comment 3
2017-06-29 21:47:03 PDT
Created
attachment 314228
[details]
Patch
Ross Kirsling
Comment 4
2017-06-29 22:06:24 PDT
Created
attachment 314234
[details]
Patch
WebKit Commit Bot
Comment 5
2017-06-30 09:12:21 PDT
Comment on
attachment 314234
[details]
Patch Clearing flags on attachment: 314234 Committed
r218999
: <
http://trac.webkit.org/changeset/218999
>
WebKit Commit Bot
Comment 6
2017-06-30 09:12:23 PDT
All reviewed patches have been landed. Closing bug.
Tim Horton
Comment 7
2017-08-14 14:03:49 PDT
No, we should be /able/ to build without the prefix header, it’s just about build time optimization. See the commment at the top of the file.
Tim Horton
Comment 8
2017-08-14 14:04:12 PDT
Uhh, wrong bug
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug