Make Legacy EME API controlled by RuntimeEnabled setting.
Created attachment 314188 [details] Patch
Can this use Settings instead? If these is something missing from the bindings generator that is prohibiting it, I can add that. Note, that [EnabledBySetting] works in most cases.
(In reply to Sam Weinig from comment #2) > Can this use Settings instead? If these is something missing from the > bindings generator that is prohibiting it, I can add that. Note, that > [EnabledBySetting] works in most cases. A setting is fine with me; I'll update the patch.
(In reply to Jer Noble from comment #3) > (In reply to Sam Weinig from comment #2) > > Can this use Settings instead? If these is something missing from the > > bindings generator that is prohibiting it, I can add that. Note, that > > [EnabledBySetting] works in most cases. > > A setting is fine with me; I'll update the patch. Hm, I may have spoken too fast. I'm not sure you can disable an entire interface with settings yet. I'll add that.
Comment on attachment 314188 [details] Patch Attachment 314188 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4022734 New failing tests: media/encrypted-media/encrypted-media-v2-syntax.html media/encrypted-media/encrypted-media-constants.html media/encrypted-media/encrypted-media-session-lifetime.html http/tests/media/clearkey/clear-key-hls-aes128.html fast/events/webkit-media-key-events-constructor.html media/encrypted-media/encrypted-media-v2-events.html media/encrypted-media/encrypted-media-is-type-supported.html
Created attachment 314198 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 314188 [details] Patch Attachment 314188 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4022801 New failing tests: media/encrypted-media/encrypted-media-v2-syntax.html media/encrypted-media/encrypted-media-session-lifetime.html media/encrypted-media/encrypted-media-constants.html http/tests/media/clearkey/clear-key-hls-aes128.html fast/events/webkit-media-key-events-constructor.html media/encrypted-media/encrypted-media-v2-events.html media/encrypted-media/encrypted-media-is-type-supported.html
Created attachment 314202 [details] Archive of layout-test-results from ews114 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-elcapitan Platform: Mac OS X 10.11.6
(In reply to Sam Weinig from comment #4) > (In reply to Jer Noble from comment #3) > > (In reply to Sam Weinig from comment #2) > > > Can this use Settings instead? If these is something missing from the > > > bindings generator that is prohibiting it, I can add that. Note, that > > > [EnabledBySetting] works in most cases. > > > > A setting is fine with me; I'll update the patch. > > Hm, I may have spoken too fast. I'm not sure you can disable an entire > interface with settings yet. I'll add that. Actually, you can. Jeeze, I'm having trouble remember what works tonight.
(In reply to Sam Weinig from comment #9) > (In reply to Sam Weinig from comment #4) > > (In reply to Jer Noble from comment #3) > > > (In reply to Sam Weinig from comment #2) > > > > Can this use Settings instead? If these is something missing from the > > > > bindings generator that is prohibiting it, I can add that. Note, that > > > > [EnabledBySetting] works in most cases. > > > > > > A setting is fine with me; I'll update the patch. > > > > Hm, I may have spoken too fast. I'm not sure you can disable an entire > > interface with settings yet. I'll add that. > > Actually, you can. Jeeze, I'm having trouble remember what works tonight. Sam and I looked into this, and there's a bug in the bindings if you use both EnabledAtRuntime and EnabledBySetting on a window exposed object. So I'll just use RuntimeEnabledFeature for this now, and he'll fix everything at once at a later date.
Created attachment 314273 [details] Patch
Comment on attachment 314273 [details] Patch Actually...just kidding! r=me
Comment on attachment 314273 [details] Patch Rejecting attachment 314273 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 314273, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: .webkit.org/git/WebKit f2ed8ac..d216288 master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 219009 = f2ed8acf000e1b135354e2a6f639957f7f85266a r219010 = d216288f7701c4470c504e3ad9e58f929677c6ab Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/4028343
Committed r219012: <http://trac.webkit.org/changeset/219012>
<rdar://problem/33084847>