Bug 173985 - Web Inspector: Cleanup unused/invalid parameters for SidebarPanels
Summary: Web Inspector: Cleanup unused/invalid parameters for SidebarPanels
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-29 12:53 PDT by Devin Rousso
Modified: 2017-06-29 17:41 PDT (History)
3 users (show)

See Also:


Attachments
Patch (13.27 KB, patch)
2017-06-29 14:30 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2017-06-29 12:53:50 PDT
Now that we have shifted to using WebInspector.instanceForClass, any object that is constructed via that function will never have values passed to it's constructor.  We should remove/cleanup any parameters that are still listed.
Comment 1 Devin Rousso 2017-06-29 14:30:20 PDT
Created attachment 314168 [details]
Patch
Comment 2 Joseph Pecoraro 2017-06-29 17:13:01 PDT
Comment on attachment 314168 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2017-06-29 17:41:07 PDT
Comment on attachment 314168 [details]
Patch

Clearing flags on attachment: 314168

Committed r218975: <http://trac.webkit.org/changeset/218975>
Comment 4 WebKit Commit Bot 2017-06-29 17:41:09 PDT
All reviewed patches have been landed.  Closing bug.