Bug 173983 – Web Inspector: Provide a way for creating a new tab but not making it immediately selected

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

This would be useful for creating background tabs, such as if multiple recordings are captured at once.

[Devin Rousso]

Created attachment 314157 [details]
Patch

[Matt Baker]

I think we should discuss this as a team before moving foreard. I'm not convinced having a tab "per recording" for canvases is a good idea.

[Devin Rousso]

(In reply to Matt Baker from comment #2)
> I think we should discuss this as a team before moving foreard. I'm not
> convinced having a tab "per recording" for canvases is a good idea.

This is unrelated to this change.  All this change does is allow tabs to be created and not immediately selected.  What you described is not made possible by this change.

[Matt Baker]

(In reply to Devin Rousso from comment #3)
> (In reply to Matt Baker from comment #2)
> > I think we should discuss this as a team before moving foreard. I'm not
> > convinced having a tab "per recording" for canvases is a good idea.
> 
> This is unrelated to this change.  All this change does is allow tabs to be
> created and not immediately selected.  What you described is not made
> possible by this change.

I should have looked more closely. Your initial description made me think it had to do with multiple tabs per recording.

If this isn't being used yet, it should probably wait (at least until a bug can be added to "Blocks").

[Joseph Pecoraro]

Comment on attachment 314157 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314157&action=review

> Source/WebInspectorUI/UserInterface/Base/Main.js:-1123
> -    if (representedObject instanceof WebInspector.Collection)
> -        return WebInspector.CollectionContentView;

Why is this getting removed?

[Joseph Pecoraro]

Comment on attachment 314157 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314157&action=review

>> Source/WebInspectorUI/UserInterface/Base/Main.js:-1123
>> -        return WebInspector.CollectionContentView;
> 
> Why is this getting removed?

r=me, but this deserves a comment in the ChangeLog. It looks like it is just bad code, but its not in line with the rest of the patch so it deserves a specific comment.

[Devin Rousso]

Created attachment 314204 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 314204 [details]
Patch

Clearing flags on attachment: 314204

Committed r218984: <http://trac.webkit.org/changeset/218984>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.