Bug 173976 - Slight clean up of WebResourceLoadStatisticsStore
Summary: Slight clean up of WebResourceLoadStatisticsStore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-29 10:53 PDT by Chris Dumez
Modified: 2017-06-29 12:51 PDT (History)
5 users (show)

See Also:


Attachments
Patch (9.84 KB, patch)
2017-06-29 10:58 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (9.83 KB, patch)
2017-06-29 11:13 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (10.10 KB, patch)
2017-06-29 11:52 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-06-29 10:53:51 PDT
Slight clean up of WebResourceLoadStatisticsStore.
Comment 1 Chris Dumez 2017-06-29 10:58:36 PDT
Created attachment 314143 [details]
Patch
Comment 2 Chris Dumez 2017-06-29 11:13:05 PDT
Created attachment 314145 [details]
Patch
Comment 3 Brent Fulgham 2017-06-29 11:48:50 PDT
Comment on attachment 314145 [details]
Patch

r=me. I'm not sure why the WPE bot is red though. Doesn't seem like your changes should have affected it.
Comment 4 Chris Dumez 2017-06-29 11:49:59 PDT
(In reply to Brent Fulgham from comment #3)
> Comment on attachment 314145 [details]
> Patch
> 
> r=me. I'm not sure why the WPE bot is red though. Doesn't seem like your
> changes should have affected it.

ource/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/WebResourceLoadStatisticsStore.cpp.o.d -o Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/WebResourceLoadStatisticsStore.cpp.o -c /home/ews/igalia-wpe-ews/WebKit/Source/WebKit2/UIProcess/WebResourceLoadStatisticsStore.cpp
/home/ews/igalia-wpe-ews/WebKit/Source/WebKit2/UIProcess/WebResourceLoadStatisticsStore.cpp: In function 'const WTF::OptionSet<WebKit::WebsiteDataType>& WebKit::dataTypesToRemove()':
/home/ews/igalia-wpe-ews/WebKit/Source/WebKit2/UIProcess/WebResourceLoadStatisticsStore.cpp:62:103: error: variable 'WTF::NeverDestroyed<WTF::OptionSet<WebKit::WebsiteDataType> > dataTypes' has initializer but incomplete type

Will fix before landing.
Comment 5 Chris Dumez 2017-06-29 11:52:58 PDT
Created attachment 314148 [details]
Patch
Comment 6 WebKit Commit Bot 2017-06-29 12:51:09 PDT
Comment on attachment 314148 [details]
Patch

Clearing flags on attachment: 314148

Committed r218958: <http://trac.webkit.org/changeset/218958>
Comment 7 WebKit Commit Bot 2017-06-29 12:51:10 PDT
All reviewed patches have been landed.  Closing bug.