Bug 173973 - Make InlineBox::m_topLeft and m_logicalWidth protected.
Summary: Make InlineBox::m_topLeft and m_logicalWidth protected.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-29 10:24 PDT by zalan
Modified: 2017-06-29 11:47 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.28 KB, patch)
2017-06-29 10:35 PDT, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2017-06-29 10:24:49 PDT 
Why are they public!
Comment 1 zalan 2017-06-29 10:25:21 PDT 
lol
https://trac.webkit.org/browser/webkit/trunk/WebCore/rendering/InlineBox.h?rev=21249

// FIXME: Would like to make this protected, but methods are accessing these members over in the part.
Comment 2 zalan 2017-06-29 10:35:20 PDT 
Created attachment 314141 [details]
Patch
Comment 3 WebKit Commit Bot 2017-06-29 11:47:28 PDT 
Comment on attachment 314141 [details]
Patch

Clearing flags on attachment: 314141

Committed r218950: <http://trac.webkit.org/changeset/218950>
Comment 4 WebKit Commit Bot 2017-06-29 11:47:30 PDT 
All reviewed patches have been landed.  Closing bug.