WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
173961
[WebIDL] Add a new extended attribute to model the forced return value optimization used on Node and Crypto
https://bugs.webkit.org/show_bug.cgi?id=173961
Summary
[WebIDL] Add a new extended attribute to model the forced return value optimi...
Sam Weinig
Reported
2017-06-28 22:15:48 PDT
[WebIDL] Add a new extended attribute to model the forced return value optimization used on Node and Crypto
Attachments
Patch
(26.60 KB, patch)
2017-06-28 22:24 PDT
,
Sam Weinig
no flags
Details
Formatted Diff
Diff
Patch
(26.65 KB, patch)
2017-06-29 07:31 PDT
,
Sam Weinig
darin
: review+
buildbot
: commit-queue-
Details
Formatted Diff
Diff
Archive of layout-test-results from ews106 for mac-elcapitan-wk2
(1.09 MB, application/zip)
2017-06-29 08:42 PDT
,
Build Bot
no flags
Details
Archive of layout-test-results from ews121 for ios-simulator-wk2
(921.17 KB, application/zip)
2017-06-29 09:04 PDT
,
Build Bot
no flags
Details
Archive of layout-test-results from ews117 for mac-elcapitan
(1.74 MB, application/zip)
2017-06-29 09:07 PDT
,
Build Bot
no flags
Details
Patch
(29.17 KB, patch)
2017-06-29 12:43 PDT
,
Sam Weinig
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews101 for mac-elcapitan
(996.22 KB, application/zip)
2017-06-29 13:33 PDT
,
Build Bot
no flags
Details
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
2017-06-28 22:24:40 PDT
Created
attachment 314112
[details]
Patch
Sam Weinig
Comment 2
2017-06-29 07:31:14 PDT
Created
attachment 314134
[details]
Patch
Build Bot
Comment 3
2017-06-29 08:42:58 PDT
Comment on
attachment 314134
[details]
Patch
Attachment 314134
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-queues.webkit.org/results/4019954
New failing tests: js/dom/dot-node-base-exception.html
Build Bot
Comment 4
2017-06-29 08:42:59 PDT
Created
attachment 314135
[details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Build Bot
Comment 5
2017-06-29 09:04:56 PDT
Comment on
attachment 314134
[details]
Patch
Attachment 314134
[details]
did not pass ios-sim-ews (ios-simulator-wk2): Output:
http://webkit-queues.webkit.org/results/4019969
New failing tests: js/dom/dot-node-base-exception.html
Build Bot
Comment 6
2017-06-29 09:04:58 PDT
Created
attachment 314136
[details]
Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5
Build Bot
Comment 7
2017-06-29 09:07:01 PDT
Comment on
attachment 314134
[details]
Patch
Attachment 314134
[details]
did not pass mac-debug-ews (mac): Output:
http://webkit-queues.webkit.org/results/4019977
New failing tests: js/dom/dot-node-base-exception.html
Build Bot
Comment 8
2017-06-29 09:07:02 PDT
Created
attachment 314137
[details]
Archive of layout-test-results from ews117 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Darin Adler
Comment 9
2017-06-29 11:32:08 PDT
Comment on
attachment 314134
[details]
Patch Regression test change for dot-node-base-exception.html looks like a progression. Need to resolve that somehow before landing. Regenerating the test result, removing the not-that-useful test since it is now quite obsolete and handled well by general DOM bindings testing, or broadening the test to more fully test what it originally intended to and not just covering the "too few parameters" case.
Sam Weinig
Comment 10
2017-06-29 12:43:13 PDT
Created
attachment 314153
[details]
Patch
Build Bot
Comment 11
2017-06-29 13:33:11 PDT
Comment on
attachment 314134
[details]
Patch
Attachment 314134
[details]
did not pass mac-ews (mac): Output:
http://webkit-queues.webkit.org/results/4021202
New failing tests: js/dom/dot-node-base-exception.html
Build Bot
Comment 12
2017-06-29 13:33:13 PDT
Created
attachment 314158
[details]
Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6
WebKit Commit Bot
Comment 13
2017-06-29 13:38:56 PDT
Comment on
attachment 314153
[details]
Patch Clearing flags on attachment: 314153 Committed
r218960
: <
http://trac.webkit.org/changeset/218960
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug