[Cocoa] Improve performance of font lookups
Created attachment 314109 [details] Patch
<rdar://problem/31996891>
Comment on attachment 314109 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=314109&action=review > Source/WebCore/ChangeLog:11 > + No new tests because there is no behavior change. I am taking your word for the fact that there is no behavior change.
Comment on attachment 314109 [details] Patch Attachment 314109 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4018020 New failing tests: fast/text/narrow-non-breaking-space.html fast/ruby/base-shorter-than-text.html fast/text/font-weights.html fast/text/text-combine-shrink-on-color-change.html fast/text/font-weights-zh.html
Created attachment 314114 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5
It looks like there is a behavior change on iOS. 😐
Comment on attachment 314109 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=314109&action=review > Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:883 > + CFTypeRef keys[] = { kCTFontEnabledAttribute, postScriptName.startsWith('.') ? kCTFontNameAttribute : kCTFontPostScriptNameAttribute }; Why only use kCTFontPostScriptNameAttribute for visible fonts?
Comment on attachment 314109 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=314109&action=review >> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:883 >> + CFTypeRef keys[] = { kCTFontEnabledAttribute, postScriptName.startsWith('.') ? kCTFontNameAttribute : kCTFontPostScriptNameAttribute }; > > Why only use kCTFontPostScriptNameAttribute for visible fonts? It isn't necessary once we fix the case sensitivity problems.
Created attachment 314395 [details] Patch for committing
Committed r219223: <http://trac.webkit.org/changeset/219223>
Comment on attachment 314395 [details] Patch for committing View in context: https://bugs.webkit.org/attachment.cgi?id=314395&action=review > PerformanceTests/ChangeLog:9 > + * Layout/font-fallback-font-family.html: Added. This test fails, filed bug 174989.