Bug 173953 - [ResourceLoadStatistics] Simplify PrevalentResourceTelemetry struct
Summary: [ResourceLoadStatistics] Simplify PrevalentResourceTelemetry struct
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-28 19:35 PDT by Chris Dumez
Modified: 2017-06-28 22:43 PDT (History)
6 users (show)

See Also:

Attachments
Patch (5.18 KB, patch)
2017-06-28 19:36 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (5.27 KB, patch)
2017-06-28 20:31 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (4.95 KB, patch)
2017-06-28 21:02 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-06-28 19:35:20 PDT 
Simplify PrevalentResourceTelemetry struct.
Comment 1 Chris Dumez 2017-06-28 19:36:35 PDT 
Created attachment 314091 [details]
Patch
Comment 2 Chris Dumez 2017-06-28 20:30:37 PDT 
Oh Windows...

C:\cygwin\home\buildbot\WebKit\Source\WebCore\loader\ResourceLoadStatisticsStore.cpp(396): error C2664: 'void WTF::Vector<WebCore::PrevalentResourceTelemetry,0,WTF::CrashOnOverflow,16>::append(WebCore::PrevalentResourceTelemetry &&)': cannot convert argument 1 from 'initializer list' to 'WebCore::PrevalentResourceTelemetry &&' [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
  C:\cygwin\home\buildbot\WebKit\Source\WebCore\loader\ResourceLoadStatisticsStore.cpp(396): note: Reason: cannot convert from 'initializer list' to 'WebCore::PrevalentResourceTelemetry'
  C:\cygwin\home\buildbot\WebKit\Source\WebCore\loader\ResourceLoadStatisticsStore.cpp(396): note: No constructor could take the source type, or constructor overload resolution was ambiguous
Comment 3 Chris Dumez 2017-06-28 20:31:45 PDT 
Created attachment 314103 [details]
Patch
Comment 4 Chris Dumez 2017-06-28 20:57:15 PDT 
Comment on attachment 314103 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314103&action=review

> Source/WebCore/loader/ResourceLoadStatisticsStore.cpp:389
> +        sorted.append(PrevalentResourceTelemetry {

Even with an explicit PrevalentResourceTelemetry { }

Windows...
C:\cygwin\home\buildbot\WebKit\Source\WebCore\loader\ResourceLoadStatisticsStore.cpp(396): error C2440: 'initializing': cannot convert from 'initializer list' to 'WebCore::PrevalentResourceTelemetry' [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
  C:\cygwin\home\buildbot\WebKit\Source\WebCore\loader\ResourceLoadStatisticsStore.cpp(396): note: No constructor could take the source type, or constructor overload resolution was ambiguous
  Generate bindings (WebCoreTestSupportBindings)
Comment 5 Chris Dumez 2017-06-28 21:02:52 PDT 
Created attachment 314108 [details]
Patch
Comment 6 WebKit Commit Bot 2017-06-28 22:43:08 PDT 
Comment on attachment 314108 [details]
Patch

Clearing flags on attachment: 314108

Committed r218918: <http://trac.webkit.org/changeset/218918>
Comment 7 WebKit Commit Bot 2017-06-28 22:43:09 PDT 
All reviewed patches have been landed.  Closing bug.