Bug 173951 - Avoid copying statistics in ResourceLoadStatisticsStore::readDataFromDecoder()
Summary: Avoid copying statistics in ResourceLoadStatisticsStore::readDataFromDecoder()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-28 19:21 PDT by Chris Dumez
Modified: 2017-06-28 20:37 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.51 KB, patch)
2017-06-28 19:22 PDT, Chris Dumez 		rniwa: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-06-28 19:21:38 PDT 
Avoid copying statistics in ResourceLoadStatisticsStore::readDataFromDecoder().
Comment 1 Chris Dumez 2017-06-28 19:22:12 PDT 
Created attachment 314090 [details]
Patch
Comment 2 Ryosuke Niwa 2017-06-28 20:18:21 PDT 
Comment on attachment 314090 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314090&action=review

> Source/WebCore/loader/ResourceLoadStatisticsStore.cpp:141
>      }
>      }

Can we fix the indentation here?
Comment 3 Chris Dumez 2017-06-28 20:23:56 PDT 
Comment on attachment 314090 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314090&action=review

>> Source/WebCore/loader/ResourceLoadStatisticsStore.cpp:141
>>      }
> 
> Can we fix the indentation here?

This is the end of the block for a Locker. Do we usually indent those?
Comment 4 Chris Dumez 2017-06-28 20:28:53 PDT 
Committed r218912: <http://trac.webkit.org/changeset/218912>
Comment 5 Ryosuke Niwa 2017-06-28 20:37:38 PDT 
(In reply to Chris Dumez from comment #3)
> Comment on attachment 314090 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=314090&action=review
> 
> >> Source/WebCore/loader/ResourceLoadStatisticsStore.cpp:141
> >>      }
> > 
> > Can we fix the indentation here?
> 
> This is the end of the block for a Locker. Do we usually indent those?

Yeah, we do. Each block should be indented.