Bug 173950 - REGRESSION (r218842): com.apple.WebKit crash in WebKit::ProcessLauncher::launchProcess
Summary: REGRESSION (r218842): com.apple.WebKit crash in WebKit::ProcessLauncher::laun...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-06-28 18:35 PDT by Ryosuke Niwa
Modified: 2017-06-28 19:56 PDT (History)
4 users (show)

See Also:

Attachments
Fixes the bug (1.58 KB, patch)
2017-06-28 18:41 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Fixes the bug (1.60 KB, patch)
2017-06-28 18:47 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2017-06-28 18:35:48 PDT 
I'm missing a null check.
Comment 1 Ryosuke Niwa 2017-06-28 18:36:08 PDT 
<rdar://problem/33043010>
Comment 2 Ryosuke Niwa 2017-06-28 18:41:06 PDT 
Created attachment 314083 [details]
Fixes the bug
Comment 3 Chris Dumez 2017-06-28 18:42:30 PDT 
Comment on attachment 314083 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=314083&action=review

> Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm:204
> +        if (m_xpcConnection)

Should this be processLauncher->m_xpcConnection ?
Comment 4 Ryosuke Niwa 2017-06-28 18:47:14 PDT 
Created attachment 314084 [details]
Fixes the bug
Comment 5 Ryosuke Niwa 2017-06-28 18:47:50 PDT 
(In reply to Chris Dumez from comment #3)
> Comment on attachment 314083 [details]
> Fixes the bug
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=314083&action=review
> 
> > Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm:204
> > +        if (m_xpcConnection)
> 
> Should this be processLauncher->m_xpcConnection ?

Yup. Fixed.
Comment 6 Ryosuke Niwa 2017-06-28 19:56:24 PDT 
Comment on attachment 314084 [details]
Fixes the bug

Clearing flags on attachment: 314084

Committed r218911: <http://trac.webkit.org/changeset/218911>
Comment 7 Ryosuke Niwa 2017-06-28 19:56:25 PDT 
All reviewed patches have been landed.  Closing bug.