The iBooks on tvOS is not a system application but it is an AppStore application. We need to disable async image decoding for iBooks on tvOS presently through WebKit.
Created attachment 314077 [details] Patch
<rdar://problem/32516256>
Comment on attachment 314077 [details] Patch Let's wait until we've decided our general direction with async image decoding.
Comment on attachment 314077 [details] Patch Clearing flags on attachment: 314077 Committed r218961: <http://trac.webkit.org/changeset/218961>
All reviewed patches have been landed. Closing bug.
Comment on attachment 314077 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=314077&action=review > Source/WebCore/platform/graphics/BitmapImage.cpp:75 > +#if PLATFORM(IOS) > + if (!IOSApplication::isIBooks()) > +#endif > + m_allowLargeImageAsyncDecoding = settings.largeImageAsyncDecodingEnabled(); Wouldn’t it be slightly cleaner to set it to false when it is iOS iBooks instead of leaving it unset?
Comment on attachment 314077 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=314077&action=review >> Source/WebCore/platform/graphics/BitmapImage.cpp:75 >> + m_allowLargeImageAsyncDecoding = settings.largeImageAsyncDecodingEnabled(); > > Wouldn’t it be slightly cleaner to set it to false when it is iOS iBooks instead of leaving it unset? Do you mean for readability because m_allowLargeImageAsyncDecoding is initialized to false in the header file? So you recommend the following? #if PLATFORM(IOS) if (IOSApplication::isIBooks()) m_allowLargeImageAsyncDecoding = false; else #endif m_allowLargeImageAsyncDecoding = settings.largeImageAsyncDecodingEnabled(); I will do this clean up.
Committed r219125: <http://trac.webkit.org/changeset/219125>
Comment on attachment 314077 [details] Patch This should also do a linked-on-or-after check so that this workaround is not permanent.
(In reply to Simon Fraser (smfr) from comment #9) > Comment on attachment 314077 [details] > Patch > > This should also do a linked-on-or-after check so that this workaround is > not permanent. And should JUST be about Storytime, not all iBooks.
(In reply to Tim Horton from comment #10) > (In reply to Simon Fraser (smfr) from comment #9) > > Comment on attachment 314077 [details] > > Patch > > > > This should also do a linked-on-or-after check so that this workaround is > > not permanent. > > And should JUST be about Storytime, not all iBooks. Can you explain what linked-on-or-after check is? It also very helpful if you give an example for how check is implemented.
(In reply to Said Abou-Hallawa from comment #11) > (In reply to Tim Horton from comment #10) > > (In reply to Simon Fraser (smfr) from comment #9) > > > Comment on attachment 314077 [details] > > > Patch > > > > > > This should also do a linked-on-or-after check so that this workaround is > > > not permanent. > > > > And should JUST be about Storytime, not all iBooks. > > Can you explain what linked-on-or-after check is? It also very helpful if > you give an example for how check is implemented. See all uses of dyld_get_program_sdk_version in the project.