Bug 173945 – Async image decoding should be disabled for iBooks on tvOS

• Status: RESOLVED
• Resolution: FIXED
• Component: Images

[Said Abou-Hallawa]

The iBooks on tvOS is not a system application but it is an AppStore application. We need to disable async image decoding for iBooks on tvOS presently through WebKit.

[Said Abou-Hallawa]

Created attachment 314077 [details]
Patch

[Said Abou-Hallawa]

<rdar://problem/32516256>

[Simon Fraser (smfr)]

Comment on attachment 314077 [details]
Patch

Let's wait until we've decided our general direction with async image decoding.

[WebKit Commit Bot]

Comment on attachment 314077 [details]
Patch

Clearing flags on attachment: 314077

Committed r218961: <http://trac.webkit.org/changeset/218961>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 314077 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314077&action=review

> Source/WebCore/platform/graphics/BitmapImage.cpp:75
> +#if PLATFORM(IOS)
> +    if (!IOSApplication::isIBooks())
> +#endif
> +        m_allowLargeImageAsyncDecoding = settings.largeImageAsyncDecodingEnabled();

Wouldn’t it be slightly cleaner to set it to false when it is iOS iBooks instead of leaving it unset?

[Said Abou-Hallawa]

Comment on attachment 314077 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314077&action=review

>> Source/WebCore/platform/graphics/BitmapImage.cpp:75
>> +        m_allowLargeImageAsyncDecoding = settings.largeImageAsyncDecodingEnabled();
> 
> Wouldn’t it be slightly cleaner to set it to false when it is iOS iBooks instead of leaving it unset?

Do you mean for readability because m_allowLargeImageAsyncDecoding is initialized to false in the header file? So you recommend the following?

#if PLATFORM(IOS)
    if (IOSApplication::isIBooks())
        m_allowLargeImageAsyncDecoding = false;
    else 
#endif
        m_allowLargeImageAsyncDecoding = settings.largeImageAsyncDecodingEnabled();

I will do this clean up.

[Said Abou-Hallawa]

Committed r219125: <http://trac.webkit.org/changeset/219125>

[Simon Fraser (smfr)]

Comment on attachment 314077 [details]
Patch

This should also do a linked-on-or-after check so that this workaround is not permanent.

[Tim Horton]

(In reply to Simon Fraser (smfr) from comment #9)
> Comment on attachment 314077 [details]
> Patch
> 
> This should also do a linked-on-or-after check so that this workaround is
> not permanent.

And should JUST be about Storytime, not all iBooks.

[Said Abou-Hallawa]

(In reply to Tim Horton from comment #10)
> (In reply to Simon Fraser (smfr) from comment #9)
> > Comment on attachment 314077 [details]
> > Patch
> > 
> > This should also do a linked-on-or-after check so that this workaround is
> > not permanent.
> 
> And should JUST be about Storytime, not all iBooks.

Can you explain what linked-on-or-after check is? It also very helpful if you give an example for how check is implemented.

[Tim Horton]

(In reply to Said Abou-Hallawa from comment #11)
> (In reply to Tim Horton from comment #10)
> > (In reply to Simon Fraser (smfr) from comment #9)
> > > Comment on attachment 314077 [details]
> > > Patch
> > > 
> > > This should also do a linked-on-or-after check so that this workaround is
> > > not permanent.
> > 
> > And should JUST be about Storytime, not all iBooks.
> 
> Can you explain what linked-on-or-after check is? It also very helpful if
> you give an example for how check is implemented.

See all uses of dyld_get_program_sdk_version in the project.