Bug 173942 - WebsiteDataRecords for credential data don't have displayName set
Summary: WebsiteDataRecords for credential data don't have displayName set
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
Keywords: InRadar
Depends on:
Reported: 2017-06-28 15:41 PDT by Ansh Shukla
Modified: 2020-05-30 19:30 PDT (History)
3 users (show)

See Also:

patch v1 (29.36 KB, application/mbox)
2017-06-30 16:20 PDT, Ansh Shukla
no flags Details
patch v1 (25.61 KB, patch)
2017-06-30 16:26 PDT, Ansh Shukla
beidson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ansh Shukla 2017-06-28 15:41:58 PDT
In Bug 171217 (https://bugs.webkit.org/show_bug.cgi?id=171217), we started surfacing website data records of type _WKWebsiteDataTypeCredentials to represent HTTP authentication state. However, the WebsiteDataRecord objects for those HTTP credentials have nil displayName. This is required for Safari to properly surface this data in UI.
Comment 1 Ansh Shukla 2017-06-30 16:20:01 PDT
Created attachment 314313 [details]
patch v1
Comment 2 Ansh Shukla 2017-06-30 16:26:04 PDT
Created attachment 314316 [details]
patch v1
Comment 3 Brady Eidson 2017-06-30 16:51:00 PDT
Comment on attachment 314316 [details]
patch v1

Comment 4 Radar WebKit Bug Importer 2017-07-04 04:32:06 PDT
Comment 5 Maciej Stachowiak 2020-05-30 19:14:01 PDT
Comment on attachment 314313 [details]
patch v1

Uflagging, it seems like the patch was accidentally submitted twice.
Comment 6 Maciej Stachowiak 2020-05-30 19:14:23 PDT
This has been reviewed but seemingly not landed. Is it still good to go?
Comment 7 Maciej Stachowiak 2020-05-30 19:30:46 PDT
(Unfortunately, it seems the patch no longer applies, so it will need to be updated.)