WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
173934
Web Inspector: Cleanup Protocol JSON files
https://bugs.webkit.org/show_bug.cgi?id=173934
Summary
Web Inspector: Cleanup Protocol JSON files
Joseph Pecoraro
Reported
2017-06-28 12:15:13 PDT
Cleanup Protocol JSON files The placement of "description" has bugged me forever. Update all the JSON files to be consistent.
Attachments
[PATCH] Proposed Fix
(99.54 KB, patch)
2017-06-28 12:16 PDT
,
Joseph Pecoraro
mattbaker
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1
2017-06-28 12:16:10 PDT
Created
attachment 314048
[details]
[PATCH] Proposed Fix
Matt Baker
Comment 2
2017-06-28 12:33:25 PDT
Comment on
attachment 314048
[details]
[PATCH] Proposed Fix View in context:
https://bugs.webkit.org/attachment.cgi?id=314048&action=review
r=me, let's fix up some of these typos while we're at it!
> Source/JavaScriptCore/inspector/protocol/DOM.json:434 > { "name": "nodeId", "$ref": "NodeId", "description": "Id of the node to retrieve attibutes for." }
attibutes -> attributes
> Source/JavaScriptCore/inspector/protocol/DOM.json:499 > { "name": "name", "type": "string", "description": "A ttribute name." }
A ttribute -> Attribute
> Source/JavaScriptCore/inspector/protocol/DOM.json:530 > { "name": "previousNodeId", "$ref": "NodeId", "description": "If of the previous siblint." },
siblint -> sibling
> Source/JavaScriptCore/inspector/protocol/DOMDebugger.json:63 > { "name": "isRegex", "type": "boolean", "optional": true, "descriprion": "Whether the URL string is a regular expression." }
descriprion -> description
> Source/JavaScriptCore/inspector/protocol/Debugger.json:42 > { "name": "data", "type": "string", "optional": true, "description": "Data associated with this breakpoint type (e.g. for type \"eval\" this is the JavaScript string to evalulate)." },
evalulate -> evaluate
> Source/JavaScriptCore/inspector/protocol/Page.json:140 > { "name": "url", "type": "string", "description": "URL to match cooke domain and path." }
cooke -> cookie
> Source/JavaScriptCore/inspector/protocol/Runtime.json:328 > + "description": "Returns detailed informtation on given function.",
informtation -> information
> Source/JavaScriptCore/inspector/protocol/Runtime.json:368 > { "name": "context", "$ref": "ExecutionContextDescription", "description": "A newly created execution contex." }
contex -> context
Joseph Pecoraro
Comment 3
2017-06-28 15:50:45 PDT
Great catches!
Joseph Pecoraro
Comment 4
2017-06-28 15:54:17 PDT
<
https://trac.webkit.org/r218898
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug