Bug 173934 - Web Inspector: Cleanup Protocol JSON files
Summary: Web Inspector: Cleanup Protocol JSON files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-28 12:15 PDT by Joseph Pecoraro
Modified: 2017-06-28 15:54 PDT (History)
8 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (99.54 KB, patch)
2017-06-28 12:16 PDT, Joseph Pecoraro
mattbaker: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2017-06-28 12:15:13 PDT
Cleanup Protocol JSON files

The placement of "description" has bugged me forever. Update all the JSON files to be consistent.
Comment 1 Joseph Pecoraro 2017-06-28 12:16:10 PDT
Created attachment 314048 [details]
[PATCH] Proposed Fix
Comment 2 Matt Baker 2017-06-28 12:33:25 PDT
Comment on attachment 314048 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=314048&action=review

r=me, let's fix up some of these typos while we're at it!

> Source/JavaScriptCore/inspector/protocol/DOM.json:434
>                  { "name": "nodeId", "$ref": "NodeId", "description": "Id of the node to retrieve attibutes for." }

attibutes -> attributes

> Source/JavaScriptCore/inspector/protocol/DOM.json:499
>                  { "name": "name", "type": "string", "description": "A ttribute name." }

A ttribute -> Attribute

> Source/JavaScriptCore/inspector/protocol/DOM.json:530
>                  { "name": "previousNodeId", "$ref": "NodeId", "description": "If of the previous siblint." },

siblint -> sibling

> Source/JavaScriptCore/inspector/protocol/DOMDebugger.json:63
>                  { "name": "isRegex", "type": "boolean", "optional": true, "descriprion": "Whether the URL string is a regular expression." }

descriprion -> description

> Source/JavaScriptCore/inspector/protocol/Debugger.json:42
>                  { "name": "data", "type": "string", "optional": true, "description": "Data associated with this breakpoint type (e.g. for type \"eval\" this is the JavaScript string to evalulate)." },

evalulate -> evaluate

> Source/JavaScriptCore/inspector/protocol/Page.json:140
>                  { "name": "url", "type": "string", "description": "URL to match cooke domain and path." }

cooke -> cookie

> Source/JavaScriptCore/inspector/protocol/Runtime.json:328
> +            "description": "Returns detailed informtation on given function.",

informtation -> information

> Source/JavaScriptCore/inspector/protocol/Runtime.json:368
>                  { "name": "context", "$ref": "ExecutionContextDescription", "description": "A newly created execution contex." }

contex -> context
Comment 3 Joseph Pecoraro 2017-06-28 15:50:45 PDT
Great catches!
Comment 4 Joseph Pecoraro 2017-06-28 15:54:17 PDT
<https://trac.webkit.org/r218898>