WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
173927
[iOS DnD] [WK2] Dragged content flashes after the preview sets down when cancelling a drag
https://bugs.webkit.org/show_bug.cgi?id=173927
Summary
[iOS DnD] [WK2] Dragged content flashes after the preview sets down when canc...
Wenson Hsieh
Reported
2017-06-28 09:25:00 PDT
<
rdar://problem/33020792
>
Attachments
Patch
(5.08 KB, patch)
2017-06-28 10:42 PDT
,
Wenson Hsieh
thorton
: review+
Details
Formatted Diff
Diff
Patch for landing
(4.96 KB, patch)
2017-06-28 12:21 PDT
,
Wenson Hsieh
no flags
Details
Formatted Diff
Diff
Adjust for UIKit changes
(4.51 KB, patch)
2017-06-28 15:41 PDT
,
Wenson Hsieh
thorton
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Wenson Hsieh
Comment 1
2017-06-28 10:42:52 PDT
Created
attachment 314039
[details]
Patch
Wenson Hsieh
Comment 2
2017-06-28 11:36:59 PDT
Comment on
attachment 314039
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=314039&action=review
> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:4611 > + RELEASE_LOG(DragAndDrop, "Drag lift completed with position: %tu", finalPosition);
I didn't mean to include this logging (this information isn't very useful). I'll remove it.
Wenson Hsieh
Comment 3
2017-06-28 12:21:40 PDT
Created
attachment 314050
[details]
Patch for landing
WebKit Commit Bot
Comment 4
2017-06-28 12:35:42 PDT
Comment on
attachment 314050
[details]
Patch for landing Clearing flags on attachment: 314050 Committed
r218885
: <
http://trac.webkit.org/changeset/218885
>
Wenson Hsieh
Comment 5
2017-06-28 15:39:13 PDT
Reopening for a followup to adjust for additional UIKit changes.
Wenson Hsieh
Comment 6
2017-06-28 15:41:20 PDT
Created
attachment 314061
[details]
Adjust for UIKit changes
Tim Horton
Comment 7
2017-06-28 15:45:58 PDT
Comment on
attachment 314061
[details]
Adjust for UIKit changes View in context:
https://bugs.webkit.org/attachment.cgi?id=314061&action=review
> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:4674 > + RetainPtr<WKContentView> protectedSelf(self);
makeRetainPtr? protectedSelf = makeRetainPtr(self)
Wenson Hsieh
Comment 8
2017-06-28 15:50:29 PDT
Comment on
attachment 314061
[details]
Adjust for UIKit changes View in context:
https://bugs.webkit.org/attachment.cgi?id=314061&action=review
>> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:4674 >> + RetainPtr<WKContentView> protectedSelf(self); > > makeRetainPtr? protectedSelf = makeRetainPtr(self)
👍 protectedSelf = retainPtr(self)
Wenson Hsieh
Comment 9
2017-06-28 16:38:53 PDT
Landed in <
http://trac.webkit.org/r218899
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug