Bug 173927 - [iOS DnD] [WK2] Dragged content flashes after the preview sets down when cancelling a drag
Summary: [iOS DnD] [WK2] Dragged content flashes after the preview sets down when canc...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-06-28 09:25 PDT by Wenson Hsieh
Modified: 2017-06-28 16:38 PDT (History)
5 users (show)

See Also:

Attachments
Patch (5.08 KB, patch)
2017-06-28 10:42 PDT, Wenson Hsieh 		thorton: review+
Details | Formatted Diff | Diff
Patch for landing (4.96 KB, patch)
2017-06-28 12:21 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Adjust for UIKit changes (4.51 KB, patch)
2017-06-28 15:41 PDT, Wenson Hsieh 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2017-06-28 09:25:00 PDT 
<rdar://problem/33020792>
Comment 1 Wenson Hsieh 2017-06-28 10:42:52 PDT 
Created attachment 314039 [details]
Patch
Comment 2 Wenson Hsieh 2017-06-28 11:36:59 PDT 
Comment on attachment 314039 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314039&action=review

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:4611
> +        RELEASE_LOG(DragAndDrop, "Drag lift completed with position: %tu", finalPosition);

I didn't mean to include this logging (this information isn't very useful). I'll remove it.
Comment 3 Wenson Hsieh 2017-06-28 12:21:40 PDT 
Created attachment 314050 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2017-06-28 12:35:42 PDT 
Comment on attachment 314050 [details]
Patch for landing

Clearing flags on attachment: 314050

Committed r218885: <http://trac.webkit.org/changeset/218885>
Comment 5 Wenson Hsieh 2017-06-28 15:39:13 PDT 
Reopening for a followup to adjust for additional UIKit changes.
Comment 6 Wenson Hsieh 2017-06-28 15:41:20 PDT 
Created attachment 314061 [details]
Adjust for UIKit changes
Comment 7 Tim Horton 2017-06-28 15:45:58 PDT 
Comment on attachment 314061 [details]
Adjust for UIKit changes

View in context: https://bugs.webkit.org/attachment.cgi?id=314061&action=review

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:4674
> +    RetainPtr<WKContentView> protectedSelf(self);

makeRetainPtr? protectedSelf = makeRetainPtr(self)
Comment 8 Wenson Hsieh 2017-06-28 15:50:29 PDT 
Comment on attachment 314061 [details]
Adjust for UIKit changes

View in context: https://bugs.webkit.org/attachment.cgi?id=314061&action=review

>> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:4674
>> +    RetainPtr<WKContentView> protectedSelf(self);
> 
> makeRetainPtr? protectedSelf = makeRetainPtr(self)

👍 protectedSelf = retainPtr(self)
Comment 9 Wenson Hsieh 2017-06-28 16:38:53 PDT 
Landed in <http://trac.webkit.org/r218899>