* Both tests are converted to use specialized CMake modules * Both libraries are now linked only if they are really needed and usable by compiler * librt is no more required to be detected by find_library(), which may fail in case of cross-compilation * librt test moved to port-independent CMakeLists.txt
Created attachment 314018 [details] Patch
Attachment 314018 [details] did not pass style-queue: ERROR: Source/WebKit2/CMakeLists.txt:724: Alphabetical sorting problem. """ should be before "int main() { std::atomic<int64_t> i(0); i++; return 0; }". [list/order] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 314021 [details] Patch
Attachment 314021 [details] did not pass style-queue: ERROR: Source/WebKit2/CMakeLists.txt:724: Alphabetical sorting problem. """ should be before "int main() { std::atomic<int64_t> i(0); i++; return 0; }". [list/order] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 314021 [details] Patch Clearing flags on attachment: 314021 Committed r218888: <http://trac.webkit.org/changeset/218888>
All reviewed patches have been landed. Closing bug.