Bug 173906 - JITStubRoutine::passesFilter should use isJITPC
Summary: JITStubRoutine::passesFilter should use isJITPC
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-27 22:24 PDT by Saam Barati
Modified: 2017-06-27 23:23 PDT (History)
11 users (show)

See Also:

Attachments
patch (5.01 KB, patch)
2017-06-27 22:36 PDT, Saam Barati 		jfbastien: review+
Details | Formatted Diff | Diff
patch for landing (5.00 KB, patch)
2017-06-27 22:41 PDT, Saam Barati 		saam: commit-queue-
Details | Formatted Diff | Diff
patch for landing (5.00 KB, patch)
2017-06-27 22:43 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2017-06-27 22:24:53 PDT 
...
Comment 1 Saam Barati 2017-06-27 22:36:08 PDT 
Created attachment 313991 [details]
patch
Comment 2 JF Bastien 2017-06-27 22:38:35 PDT 
Comment on attachment 313991 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313991&action=review

r=me

> Source/JavaScriptCore/ChangeLog:9
> +        inside ExecutableAllocator.h. Before, JITStubRoutine would was using

"would was"
Comment 3 Mark Lam 2017-06-27 22:40:03 PDT 
Comment on attachment 313991 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313991&action=review

> Source/JavaScriptCore/ChangeLog:10
> +        the harcoded platform size constant. This means it'd do the wrong thing

typo: /the harcoded/a hardcoded/.

> Source/JavaScriptCore/ChangeLog:12
> +        constant for that platform. This patch also removes up a bunch of

delete "up".
Comment 4 Saam Barati 2017-06-27 22:41:00 PDT 
Created attachment 313993 [details]
patch for landing
Comment 5 Saam Barati 2017-06-27 22:43:12 PDT 
Created attachment 313994 [details]
patch for landing
Comment 6 WebKit Commit Bot 2017-06-27 23:23:27 PDT 
Comment on attachment 313994 [details]
patch for landing

Clearing flags on attachment: 313994

Committed r218867: <http://trac.webkit.org/changeset/218867>
Comment 7 WebKit Commit Bot 2017-06-27 23:23:28 PDT 
All reviewed patches have been landed.  Closing bug.