RESOLVED FIXED 173906
JITStubRoutine::passesFilter should use isJITPC 
https://bugs.webkit.org/show_bug.cgi?id=173906
Summary JITStubRoutine::passesFilter should use isJITPC
Saam Barati
Reported 2017-06-27 22:24:53 PDT
...
Attachments
patch (5.01 KB, patch)
2017-06-27 22:36 PDT, Saam Barati 		jfbastien: review+
DetailsFormatted DiffDiff
patch for landing (5.00 KB, patch)
2017-06-27 22:41 PDT, Saam Barati 		saam: commit-queue-
DetailsFormatted DiffDiff
patch for landing (5.00 KB, patch)
2017-06-27 22:43 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2017-06-27 22:36:08 PDT
Created attachment 313991 [details] patch
JF Bastien
Comment 2 2017-06-27 22:38:35 PDT
Comment on attachment 313991 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=313991&action=review r=me > Source/JavaScriptCore/ChangeLog:9 > + inside ExecutableAllocator.h. Before, JITStubRoutine would was using "would was"
Mark Lam
Comment 3 2017-06-27 22:40:03 PDT
Comment on attachment 313991 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=313991&action=review > Source/JavaScriptCore/ChangeLog:10 > + the harcoded platform size constant. This means it'd do the wrong thing typo: /the harcoded/a hardcoded/. > Source/JavaScriptCore/ChangeLog:12 > + constant for that platform. This patch also removes up a bunch of delete "up".
Saam Barati
Comment 4 2017-06-27 22:41:00 PDT
Created attachment 313993 [details] patch for landing
Saam Barati
Comment 5 2017-06-27 22:43:12 PDT
Created attachment 313994 [details] patch for landing
WebKit Commit Bot
Comment 6 2017-06-27 23:23:27 PDT
Comment on attachment 313994 [details] patch for landing Clearing flags on attachment: 313994 Committed r218867: <http://trac.webkit.org/changeset/218867>
WebKit Commit Bot
Comment 7 2017-06-27 23:23:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.