Bug 173905 - Web Inspector: Remove unused Inspector domain events
Summary: Web Inspector: Remove unused Inspector domain events
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-27 21:58 PDT by Joseph Pecoraro
Modified: 2017-06-28 15:53 PDT (History)
8 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (16.16 KB, patch)
2017-06-27 21:59 PDT, Joseph Pecoraro
mattbaker: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2017-06-27 21:58:12 PDT
As far as I can tell these has never been used by our backend/frontend. They are also unhandled so lets remove them.

    Inspector.detached
    Inspector.targetCrashed
Comment 1 Joseph Pecoraro 2017-06-27 21:59:45 PDT
Created attachment 313987 [details]
[PATCH] Proposed Fix
Comment 2 Matt Baker 2017-06-28 13:15:44 PDT
Comment on attachment 313987 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=313987&action=review

r=me

> Source/WebInspectorUI/ChangeLog:23
> +        Remove from legacy backends as well since they did not sent it.

sent -> send
Comment 3 Joseph Pecoraro 2017-06-28 15:53:50 PDT
<https://trac.webkit.org/r218897>