Bug 173885 - Web Inspector: Cleanup RemoteObject tests
Summary: Web Inspector: Cleanup RemoteObject tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-27 13:58 PDT by Joseph Pecoraro
Modified: 2017-06-27 21:24 PDT (History)
4 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (156.25 KB, patch)
2017-06-27 14:01 PDT, Joseph Pecoraro 		mattbaker: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2017-06-27 13:58:42 PDT 
Following some cleanup on RemoteObject tests after the recent changes.

  • Fix a bug causing a test to timeout
  • Separate out DOM specific objects which differ across platforms
  • One expectation file for all core JavaScript object values
  • Update syntax to use template strings as they are much better for code
Comment 1 Joseph Pecoraro 2017-06-27 14:01:11 PDT 
Created attachment 313937 [details]
[PATCH] Proposed Fix
Comment 2 Matt Baker 2017-06-27 14:10:40 PDT 
Comment on attachment 313937 [details]
[PATCH] Proposed Fix

r=me
Comment 3 Joseph Pecoraro 2017-06-27 21:24:18 PDT 
<https://trac.webkit.org/r218862>