Bug 173882 - Move WebsiteDataRecord processing off-thread in WebsiteDataStore::fetchDataForTopPrivatelyControlledDomains()
Summary: Move WebsiteDataRecord processing off-thread in WebsiteDataStore::fetchDataFo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-06-27 12:14 PDT by Chris Dumez
Modified: 2017-06-27 21:17 PDT (History)
10 users (show)

See Also:

Attachments
Patch (15.07 KB, patch)
2017-06-27 13:44 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (4.17 KB, patch)
2017-06-27 14:54 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (4.22 KB, patch)
2017-06-27 15:01 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-06-27 12:14:54 PDT 
Moved processing / filtering of data returned by WebsiteDataStore::fetchData() off the main thread.
Comment 1 Chris Dumez 2017-06-27 12:15:08 PDT 
<rdar://problem/32984366>
Comment 2 Chris Dumez 2017-06-27 13:44:22 PDT 
Created attachment 313936 [details]
Patch
Comment 3 Build Bot 2017-06-27 13:45:53 PDT 
Attachment 313936 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp:186:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp:189:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp:287:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.h:96:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 4 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Chris Dumez 2017-06-27 14:54:32 PDT 
Created attachment 313948 [details]
Patch
Comment 5 Chris Dumez 2017-06-27 15:01:36 PDT 
Created attachment 313949 [details]
Patch
Comment 6 WebKit Commit Bot 2017-06-27 18:47:18 PDT 
Comment on attachment 313949 [details]
Patch

Clearing flags on attachment: 313949

Committed r218860: <http://trac.webkit.org/changeset/218860>
Comment 7 WebKit Commit Bot 2017-06-27 18:47:20 PDT 
All reviewed patches have been landed.  Closing bug.