Bug 173868 - [Win] When running layout tests, each DRT should have a unique IndexedDB directory path.
Summary: [Win] When running layout tests, each DRT should have a unique IndexedDB dire...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-27 00:10 PDT by Per Arne Vollan
Modified: 2023-10-27 18:11 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.84 KB, patch)
2017-06-27 00:13 PDT, Per Arne Vollan 		achristensen: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2017-06-27 00:10:23 PDT 
DRTs should not share the IndexedDB directory path.
Comment 1 Per Arne Vollan 2017-06-27 00:13:02 PDT 
Created attachment 313902 [details]
Patch
Comment 2 Alex Christensen 2017-06-28 10:10:50 PDT 
Comment on attachment 313902 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313902&action=review

> Source/WebKit/win/ChangeLog:8
> +        DRTs should not share the IndexedDB directory path, as this can cause flakiness.

This change is not specific to DRT, is it?
Comment 3 Alex Christensen 2017-06-28 10:11:38 PDT 
After this change, will apps using indexeddb be able to find their files that are already stored on people's disks?
Comment 4 Per Arne Vollan 2017-06-28 22:36:24 PDT 
(In reply to Alex Christensen from comment #3)
> After this change, will apps using indexeddb be able to find their files
> that are already stored on people's disks?

That's a good point. If the app has set the 'WebDatabaseDirectory' preference, the indexeddb files will then have a new location with this patch. Otherwise, the files will be located at the same place.

Thanks for reviewing!
Comment 5 Per Arne Vollan 2017-06-28 22:39:34 PDT 
(In reply to Alex Christensen from comment #2)
> Comment on attachment 313902 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=313902&action=review
> 
> > Source/WebKit/win/ChangeLog:8
> > +        DRTs should not share the IndexedDB directory path, as this can cause flakiness.
> 
> This change is not specific to DRT, is it?

That's correct.
Comment 6 Alex Christensen 2017-06-29 12:40:40 PDT 
Comment on attachment 313902 [details]
Patch

I think this should be fixed by having DRT set the IndexedDB directory.  If there is not a way to do so, we should make a way and use the default directory if it isn't set to avoid breaking existing apps by having them not find existing files after updating WebKit.
Comment 7 Per Arne Vollan 2017-07-07 16:28:03 PDT 
(In reply to Alex Christensen from comment #6)
> Comment on attachment 313902 [details]
> Patch
> 
> I think this should be fixed by having DRT set the IndexedDB directory.  If
> there is not a way to do so, we should make a way and use the default
> directory if it isn't set to avoid breaking existing apps by having them not
> find existing files after updating WebKit.

Sounds good, Alex, I think I will create a new preference for the IndexedDB directory.

Sorry for the long response time!
Comment 8 Ahmad Saleem 2023-10-27 18:11:08 PDT 
Seems to be AppleWin port related, I think we can mark this as 'RESOLVED CONFIGURATION CHANGED'.