Bug 173850 - WebsiteDataStore::fetchDataForTopPrivatelyControlledDomains() is inefficient
Summary: WebsiteDataStore::fetchDataForTopPrivatelyControlledDomains() is inefficient
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
Depends on:
Reported: 2017-06-26 14:21 PDT by Chris Dumez
Modified: 2017-06-26 20:33 PDT (History)
10 users (show)

See Also:

Patch (16.95 KB, patch)
2017-06-26 14:26 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-06-26 14:21:30 PDT
WebsiteDataStore::fetchDataForTopPrivatelyControlledDomains() is inefficient.

Work towards <rdar://problem/32984366>.
Comment 1 Chris Dumez 2017-06-26 14:26:00 PDT
Created attachment 313868 [details]
Comment 2 Chris Dumez 2017-06-26 14:27:19 PDT
We should also look into doing the work that WebsiteDataStore::fetchDataForTopPrivatelyControlledDomains() is doing off main-thread since the operation is asynchronous and expensive.
Comment 3 Build Bot 2017-06-26 14:28:16 PDT
Attachment 313868 [details] did not pass style-queue:

ERROR: Source/WebKit2/UIProcess/WebProcessProxy.cpp:212:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/WebProcessProxy.h:144:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 10 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 WebKit Commit Bot 2017-06-26 20:33:15 PDT
Comment on attachment 313868 [details]

Clearing flags on attachment: 313868

Committed r218827: <http://trac.webkit.org/changeset/218827>
Comment 5 WebKit Commit Bot 2017-06-26 20:33:17 PDT
All reviewed patches have been landed.  Closing bug.