Bug 173843 - Disable m_temporarilyAllowingInlinePlaybackAfterFullscreen on pause
Summary: Disable m_temporarilyAllowingInlinePlaybackAfterFullscreen on pause
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jeremy Jones
Keywords: InRadar
Depends on:
Reported: 2017-06-26 11:00 PDT by Jeremy Jones
Modified: 2017-11-02 11:45 PDT (History)
4 users (show)

See Also:

Patch (5.56 KB, patch)
2017-06-26 19:30 PDT, Jeremy Jones
eric.carlson: review+
Details | Formatted Diff | Diff
Patch for landing. (5.80 KB, patch)
2017-06-27 13:40 PDT, Jeremy Jones
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Jones 2017-06-26 11:00:30 PDT
Disable m_temporarilyAllowingInlinePlaybackAfterFullscreen on pause
Comment 1 Jeremy Jones 2017-06-26 11:02:31 PDT
Comment 2 Jeremy Jones 2017-06-26 19:30:14 PDT
Created attachment 313888 [details]
Comment 3 Eric Carlson 2017-06-27 05:17:36 PDT
Comment on attachment 313888 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=313888&action=review

> LayoutTests/media/media-fullscreen-pause-inline-expected.txt:1
> +CONSOLE MESSAGE: Unhandled Promise Rejection: [object DOMError]

I think it would be better to handle and log the rejected promise so it shows up in the in-page results when the test is run manually.
Comment 4 Jeremy Jones 2017-06-27 13:40:33 PDT
Created attachment 313935 [details]
Patch for landing.
Comment 5 WebKit Commit Bot 2017-06-27 15:39:24 PDT
Comment on attachment 313935 [details]
Patch for landing.

Clearing flags on attachment: 313935

Committed r218847: <http://trac.webkit.org/changeset/218847>