Bug 173838 - [iOS DnD] [WK2] Beginning a drag session should prevent clicking via long press
Summary: [iOS DnD] [WK2] Beginning a drag session should prevent clicking via long press
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-26 09:55 PDT by Wenson Hsieh
Modified: 2021-05-24 14:20 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.04 KB, patch)
2017-06-26 10:02 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2017-06-26 09:55:56 PDT 
After r218579, WebKit no longer attempts to replace out-of-the-box UIKit long-press/drag lift disambiguation by firing events immediately. However, this means that dragging will defer the highlight long press gesture recognizer until dragging ends rather than cancel it immediately, which causes WKContentView to dispatch a synthetic click immediately upon lift. To fix this, we should bail out of the highlight long press gesture when beginning a drag.
Comment 1 Wenson Hsieh 2017-06-26 10:02:22 PDT 
Created attachment 313849 [details]
Patch
Comment 2 WebKit Commit Bot 2017-06-26 10:54:41 PDT 
Comment on attachment 313849 [details]
Patch

Clearing flags on attachment: 313849

Committed r218812: <http://trac.webkit.org/changeset/218812>
Comment 3 WebKit Commit Bot 2017-06-26 10:54:43 PDT 
All reviewed patches have been landed.  Closing bug.