RESOLVED FIXED 173836
[TestWebKitAPI] REGRESSION (r218750): Fix leak of NSURLResponse in WKURLSchemeHandler-1.mm 
https://bugs.webkit.org/show_bug.cgi?id=173836
Summary [TestWebKitAPI] REGRESSION (r218750): Fix leak of NSURLResponse in WKURLSchem...
David Kilzer (:ddkilzer)
Reported 2017-06-26 09:38:47 PDT
Commit r218750 introduced a leak of an NSURLResponse object in WKURLSchemeHandler-1.mm. Bug 173730: Add SPI to WKURLSchemeTask for redirection <​https://bugs.webkit.org/show_bug.cgi?id=173730> <https://trac.webkit.org/r218750>
Attachments
Patch v1 (2.86 KB, patch)
2017-06-26 09:40 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2017-06-26 09:40:47 PDT
Created attachment 313845 [details] Patch v1
Brady Eidson
Comment 2 2017-06-26 10:19:22 PDT
Comment on attachment 313845 [details] Patch v1 Alex--!!! (And whoever reviewed that!)
WebKit Commit Bot
Comment 3 2017-06-26 10:48:39 PDT
Comment on attachment 313845 [details] Patch v1 Clearing flags on attachment: 313845 Committed r218810: <http://trac.webkit.org/changeset/218810>
WebKit Commit Bot
Comment 4 2017-06-26 10:48:41 PDT
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 5 2017-06-27 17:28:28 PDT
Maybe some day we can use ARC for our tests even before we move to using ARC to compile WebKit itself.
Note You need to log in before you can comment on or make changes to this bug.