Bug 173835 - Invalidate WebVideoFullscreenManager when WebPage is destroyed.
Summary: Invalidate WebVideoFullscreenManager when WebPage is destroyed.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jeremy Jones
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-06-26 09:14 PDT by Jeremy Jones
Modified: 2017-11-02 11:45 PDT (History)
5 users (show)

See Also:

Attachments
Patch (7.95 KB, patch)
2017-06-26 09:17 PDT, Jeremy Jones 		jer.noble: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (970.22 KB, application/zip)
2017-06-26 10:44 PDT, Build Bot 		no flags Details
Patch for landing. (8.55 KB, patch)
2017-06-26 13:54 PDT, Jeremy Jones 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Jones 2017-06-26 09:14:13 PDT 
Invalidate WebVideoFullscreenManager when WebPage is destroyed.
Comment 1 Jeremy Jones 2017-06-26 09:17:51 PDT 
Created attachment 313843 [details]
Patch
Comment 2 Jeremy Jones 2017-06-26 09:18:33 PDT 
rdar://problem/32969161
Comment 3 Jeremy Jones 2017-06-26 10:36:44 PDT 
Investigating media/controls/ipad/close-page-with-picture-in-picture-video-assertion-failure.html crash to see if it is related.
Comment 4 Build Bot 2017-06-26 10:44:49 PDT 
Comment on attachment 313843 [details]
Patch

Attachment 313843 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4001435

New failing tests:
media/controls/ipad/close-page-with-picture-in-picture-video-assertion-failure.html
Comment 5 Build Bot 2017-06-26 10:44:50 PDT 
Created attachment 313850 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5
Comment 6 Jeremy Jones 2017-06-26 13:54:19 PDT 
Created attachment 313867 [details]
Patch for landing.
Comment 7 WebKit Commit Bot 2017-06-26 15:36:49 PDT 
Comment on attachment 313867 [details]
Patch for landing.

Clearing flags on attachment: 313867

Committed r218822: <http://trac.webkit.org/changeset/218822>