RESOLVED FIXED 173825
[WTF] Drop Thread::create(obsolete things) API since we can use lambda
https://bugs.webkit.org/show_bug.cgi?id=173825
Summary [WTF] Drop Thread::create(obsolete things) API since we can use lambda
Yusuke Suzuki
Reported 2017-06-25 14:05:46 PDT
[WTF] Drop Thread::create(obsolete things) API since we can use lambda
Attachments
Patch (40.68 KB, patch)
2017-06-25 14:08 PDT, Yusuke Suzuki
no flags
Patch (40.66 KB, patch)
2017-06-25 14:13 PDT, Yusuke Suzuki
no flags
Patch (41.28 KB, patch)
2017-06-25 14:21 PDT, Yusuke Suzuki
no flags
Patch (42.91 KB, patch)
2017-06-25 19:52 PDT, Yusuke Suzuki
no flags
Yusuke Suzuki
Comment 1 2017-06-25 14:08:04 PDT
Build Bot
Comment 2 2017-06-25 14:09:17 PDT
Attachment 313814 [details] did not pass style-queue: ERROR: Source/WebCore/platform/network/cf/LoaderRunLoopCF.cpp:59: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 2 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.
Yusuke Suzuki
Comment 3 2017-06-25 14:13:27 PDT
Build Bot
Comment 4 2017-06-25 14:16:12 PDT
Attachment 313815 [details] did not pass style-queue: ERROR: Source/WebCore/platform/network/cf/LoaderRunLoopCF.cpp:59: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 2 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.
Yusuke Suzuki
Comment 5 2017-06-25 14:21:00 PDT
Build Bot
Comment 6 2017-06-25 14:23:10 PDT
Attachment 313816 [details] did not pass style-queue: ERROR: Source/WebCore/platform/network/cf/LoaderRunLoopCF.cpp:59: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 1 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Adler
Comment 7 2017-06-25 16:11:28 PDT
Comment on attachment 313816 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=313816&action=review > Source/WebCore/bindings/js/GCController.cpp:104 > + RefPtr<Thread> thread = Thread::create("WebCore: GCController", collect); This is the one not compiling on Windows.
Yusuke Suzuki
Comment 8 2017-06-25 19:52:05 PDT
Build Bot
Comment 9 2017-06-25 19:55:14 PDT
Attachment 313818 [details] did not pass style-queue: ERROR: Source/WebCore/platform/network/cf/LoaderRunLoopCF.cpp:59: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 1 in 28 files If any of these errors are false positives, please file a bug against check-webkit-style.
Saam Barati
Comment 10 2017-06-26 10:25:21 PDT
Comment on attachment 313818 [details] Patch r=me
Yusuke Suzuki
Comment 11 2017-06-26 10:55:20 PDT
Comment on attachment 313818 [details] Patch Thanks!
WebKit Commit Bot
Comment 12 2017-06-26 11:19:41 PDT
Comment on attachment 313818 [details] Patch Clearing flags on attachment: 313818 Committed r218816: <http://trac.webkit.org/changeset/218816>
WebKit Commit Bot
Comment 13 2017-06-26 11:19:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.