Bug 173825 - [WTF] Drop Thread::create(obsolete things) API since we can use lambda
Summary: [WTF] Drop Thread::create(obsolete things) API since we can use lambda
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-25 14:05 PDT by Yusuke Suzuki
Modified: 2017-06-26 11:19 PDT (History)
7 users (show)

See Also:

Attachments
Patch (40.68 KB, patch)
2017-06-25 14:08 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (40.66 KB, patch)
2017-06-25 14:13 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (41.28 KB, patch)
2017-06-25 14:21 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (42.91 KB, patch)
2017-06-25 19:52 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2017-06-25 14:05:46 PDT 
[WTF] Drop Thread::create(obsolete things) API since we can use lambda
Comment 1 Yusuke Suzuki 2017-06-25 14:08:04 PDT 
Created attachment 313814 [details]
Patch
Comment 2 Build Bot 2017-06-25 14:09:17 PDT 
Attachment 313814 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/network/cf/LoaderRunLoopCF.cpp:59:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 2 in 27 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Yusuke Suzuki 2017-06-25 14:13:27 PDT 
Created attachment 313815 [details]
Patch
Comment 4 Build Bot 2017-06-25 14:16:12 PDT 
Attachment 313815 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/network/cf/LoaderRunLoopCF.cpp:59:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 2 in 27 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Yusuke Suzuki 2017-06-25 14:21:00 PDT 
Created attachment 313816 [details]
Patch
Comment 6 Build Bot 2017-06-25 14:23:10 PDT 
Attachment 313816 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/network/cf/LoaderRunLoopCF.cpp:59:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 1 in 27 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Darin Adler 2017-06-25 16:11:28 PDT 
Comment on attachment 313816 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313816&action=review

> Source/WebCore/bindings/js/GCController.cpp:104
> +    RefPtr<Thread> thread = Thread::create("WebCore: GCController", collect);

This is the one not compiling on Windows.
Comment 8 Yusuke Suzuki 2017-06-25 19:52:05 PDT 
Created attachment 313818 [details]
Patch
Comment 9 Build Bot 2017-06-25 19:55:14 PDT 
Attachment 313818 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/network/cf/LoaderRunLoopCF.cpp:59:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 1 in 28 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 10 Saam Barati 2017-06-26 10:25:21 PDT 
Comment on attachment 313818 [details]
Patch

r=me
Comment 11 Yusuke Suzuki 2017-06-26 10:55:20 PDT 
Comment on attachment 313818 [details]
Patch

Thanks!
Comment 12 WebKit Commit Bot 2017-06-26 11:19:41 PDT 
Comment on attachment 313818 [details]
Patch

Clearing flags on attachment: 313818

Committed r218816: <http://trac.webkit.org/changeset/218816>
Comment 13 WebKit Commit Bot 2017-06-26 11:19:42 PDT 
All reviewed patches have been landed.  Closing bug.