RESOLVED FIXED 173813
[WK2] Make sure encodeClientTypesAndData() / decodeClientTypesAndData() match exactly 
https://bugs.webkit.org/show_bug.cgi?id=173813
Summary [WK2] Make sure encodeClientTypesAndData() / decodeClientTypesAndData() match...
Chris Dumez
Reported 2017-06-24 15:51:14 PDT
Make sure encodeClientTypesAndData() / decodeClientTypesAndData() match exactly.
Attachments
Patch (2.79 KB, patch)
2017-06-24 15:57 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-06-24 15:57:01 PDT
Created attachment 313790 [details] Patch
WebKit Commit Bot
Comment 2 2017-06-24 17:07:21 PDT
Comment on attachment 313790 [details] Patch Clearing flags on attachment: 313790 Committed r218791: <http://trac.webkit.org/changeset/218791>
WebKit Commit Bot
Comment 3 2017-06-24 17:07:22 PDT
All reviewed patches have been landed. Closing bug.
David Kilzer (:ddkilzer)
Comment 4 2017-06-25 15:08:51 PDT
Comment on attachment 313790 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=313790&action=review > Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:1446 > + ASSERT(dataSize == types.size()); Why not RELEASE_ASSERT() here?
David Kilzer (:ddkilzer)
Comment 5 2017-06-26 09:33:53 PDT
Comment on attachment 313790 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=313790&action=review >> Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:1446 >> + ASSERT(dataSize == types.size()); > > Why not RELEASE_ASSERT() here? Talked to Chris in person. He didn't think this needs a RELEASE_ASSERT() because the new code is already using the correct vector length.
Note You need to log in before you can comment on or make changes to this bug.