Bug 173813 - [WK2] Make sure encodeClientTypesAndData() / decodeClientTypesAndData() match exactly
Summary: [WK2] Make sure encodeClientTypesAndData() / decodeClientTypesAndData() match...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-24 15:51 PDT by Chris Dumez
Modified: 2017-06-26 09:33 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.79 KB, patch)
2017-06-24 15:57 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-06-24 15:51:14 PDT 
Make sure encodeClientTypesAndData() / decodeClientTypesAndData() match exactly.
Comment 1 Chris Dumez 2017-06-24 15:57:01 PDT 
Created attachment 313790 [details]
Patch
Comment 2 WebKit Commit Bot 2017-06-24 17:07:21 PDT 
Comment on attachment 313790 [details]
Patch

Clearing flags on attachment: 313790

Committed r218791: <http://trac.webkit.org/changeset/218791>
Comment 3 WebKit Commit Bot 2017-06-24 17:07:22 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 David Kilzer (:ddkilzer) 2017-06-25 15:08:51 PDT 
Comment on attachment 313790 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313790&action=review

> Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:1446
> +    ASSERT(dataSize == types.size());

Why not RELEASE_ASSERT() here?
Comment 5 David Kilzer (:ddkilzer) 2017-06-26 09:33:53 PDT 
Comment on attachment 313790 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313790&action=review

>> Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:1446
>> +    ASSERT(dataSize == types.size());
> 
> Why not RELEASE_ASSERT() here?

Talked to Chris in person.  He didn't think this needs a RELEASE_ASSERT() because the new code is already using the correct vector length.